-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Fixes] Improve removal of resources in a retry scenario #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files ± 0 1 suites ±0 37s ⏱️ +4s Results for commit b6bcb3a. ± Comparison against base commit ee9daa0. This pull request removes 47 and adds 53 tests. Note that renamed tests count towards both.
This pull request removes 2 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
eriqua
reviewed
Dec 6, 2022
utilities/pipelines/resourceRemoval/helper/Remove-Deployment.ps1
Outdated
Show resolved
Hide resolved
rahalan
previously approved these changes
Dec 6, 2022
rahalan
approved these changes
Dec 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled pass-thru of multiple deployment names to removal script
Enabled return value of multiple deployment names in deployment script
Updated pipeline templates to pass multiple deployment names from deployment task to removal task
Updated documentation
Simplified removal output:
Pipeline references
Type of Change
Please delete options that are not relevant.