Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Transformed 'concat' folder structure into sub-folder structure + added bicep modules #25

Merged
merged 6 commits into from
Aug 31, 2021
Merged

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Aug 27, 2021

Change

Instead of structing sub-resources into a structure such as

Microsoft.Sql
├─ server [module]
└─ serverDatabases [module]

it is now instead solved like

Microsoft.Sql
├─ server [module]
└─ serverResources
     └─ databases [module]

which is in closer alignment to the ARM template reference.

Also added bicep modules for:

  • SharedImageGallery
  • ResourceGroup
  • WVDApplication
  • StorageAccount

Removed bicep module for:

  • KeyVault (as it is work in progress)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr requested a review from segraef as a code owner August 27, 2021 08:33
@AlexanderSehr AlexanderSehr changed the title Transformed 'concat' folder structure into sub-folder structure Transformed 'concat' folder structure into sub-folder structure + added bicep modules Aug 27, 2021
@segraef
Copy link
Contributor

segraef commented Aug 31, 2021

This makes more sense, Thanks.
Adjusted PR readme as well.

Microsoft.Sql
├─ server [module]
└─ serverResources
└─ databases [module]

@segraef segraef merged commit 6440080 into Azure:main Aug 31, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants