Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fixes] Diskencryptionsets and Eventgridsubscriptions tags update #2985

Merged
merged 1 commit into from
Mar 12, 2023
Merged

[Fixes] Diskencryptionsets and Eventgridsubscriptions tags update #2985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/Microsoft.Compute/diskEncryptionSets/.test/accessPolicies/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,9 @@ module testDeployment '../../deploy.bicep' = {
userAssignedIdentities: {
'${nestedDependencies.outputs.managedIdentityResourceId}': {}
}
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
}
3 changes: 0 additions & 3 deletions modules/Microsoft.Compute/diskEncryptionSets/.test/common/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ module testDeployment '../../deploy.bicep' = {
enableDefaultTelemetry: enableDefaultTelemetry
name: '<<namePrefix>>${serviceShort}001'
lock: 'CanNotDelete'
tags: {
TagKey: 'TagValue'
}
keyName: nestedDependencies.outputs.keyName
keyVaultResourceId: nestedDependencies.outputs.keyVaultResourceId
roleAssignments: [
Expand Down
10 changes: 10 additions & 0 deletions modules/Microsoft.Compute/diskEncryptionSets/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,10 @@ module diskEncryptionSets './Microsoft.Compute/diskEncryptionSets/deploy.bicep'
}
]
systemAssignedIdentity: true
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
userAssignedIdentities: {
'<managedIdentityResourceId>': {}
}
Expand Down Expand Up @@ -285,6 +289,12 @@ module diskEncryptionSets './Microsoft.Compute/diskEncryptionSets/deploy.bicep'
"systemAssignedIdentity": {
"value": true
},
"tags": {
"value": {
"Environment": "Non-Prod",
"Role": "DeploymentValidation"
}
},
"userAssignedIdentities": {
"value": {
"<managedIdentityResourceId>": {}
Expand Down
4 changes: 0 additions & 4 deletions modules/Microsoft.EventGrid/eventSubscriptions/.test/common/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,5 @@ module testDeployment '../../deploy.bicep' = {

}
}
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
}
10 changes: 0 additions & 10 deletions modules/Microsoft.EventGrid/eventSubscriptions/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ module eventSubscriptions './Microsoft.EventGrid/eventSubscriptions/deploy.bicep
eventTimeToLive: '120'
maxDeliveryAttempts: 10
}
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
}
```
Expand Down Expand Up @@ -149,12 +145,6 @@ module eventSubscriptions './Microsoft.EventGrid/eventSubscriptions/deploy.bicep
"eventTimeToLive": "120",
"maxDeliveryAttempts": 10
}
},
"tags": {
"value": {
"Environment": "Non-Prod",
"Role": "DeploymentValidation"
}
}
}
}
Expand Down