Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Modules] Updated Availability Sets Module to Latest API Version (2022-11-01) #3030

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

ahmadabdalla
Copy link
Contributor

Closes #3022

Description

Updated API Version

Pipeline
Compute - AvailabilitySets

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Mar 21, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.10.0 milestone Mar 21, 2023
@ahmadabdalla ahmadabdalla self-assigned this Mar 21, 2023
@github-actions
Copy link

Test Results

  1 files  ±  0    1 suites  ±0   33s ⏱️ -25s
46 tests  - 74  44 ✔️  - 69  2 💤  - 5  0 ±0 
50 runs   - 74  47 ✔️  - 69  3 💤  - 5  0 ±0 

Results for commit 45da617. ± Comparison against base commit 4282299.

This pull request removes 120 and adds 46 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Web/hostingEnvironments/configurations-customdnssuffix] used resource type [hostingEnvironments/configurations] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Web/hostingEnvironments/configurations-networking] used resource type [hostingEnvironments/configurations] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Web/hostingEnvironments] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Web/hostingEnvironments] used resource type [hostingEnvironments/configurations] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Web/hostingEnvironments] used resource type [hostingEnvironments] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Web/hostingEnvironments] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Web/hostingEnvironments] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Web/hostingEnvironments/configurations-customdnssuffix] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Web/hostingEnvironments/configurations-customdnssuffix] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Web/hostingEnvironments/configurations-customdnssuffix] All parameters in parameters files exist in template file (deploy.json)
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/availabilitySets] used resource type [availabilitySets] should use one of the recent API version(s). Currently using [2022-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/availabilitySets] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/availabilitySets] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/availabilitySets] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/availabilitySets] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/availabilitySets] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/availabilitySets] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/availabilitySets] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/availabilitySets] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/availabilitySets] Each parameters' description should start with a one word category starting with a capital letter, followed by a dot, a space and the actual description text ending with a dot.
…
This pull request removes 7 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Web/hostingEnvironments/configurations-customdnssuffix] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Web/hostingEnvironments/configurations-customdnssuffix] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Web/hostingEnvironments/configurations-customdnssuffix] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Web/hostingEnvironments/configurations-networking] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Web/hostingEnvironments/configurations-networking] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Web/hostingEnvironments/configurations-networking] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Web/hostingEnvironments] JSON test files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/availabilitySets] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Compute/availabilitySets] JSON test files in the .test folder should be valid json

@ahmadabdalla ahmadabdalla changed the title Updated Availability Sets Module to Latest API Version (2022-11-01) [Modules] Updated Availability Sets Module to Latest API Version (2022-11-01) Mar 21, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review March 21, 2023 06:22
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner March 21, 2023 06:22
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) March 21, 2023 06:22
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ahmadabdalla ahmadabdalla merged commit 76b4342 into main Mar 21, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/3022_as branch March 21, 2023 10:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] Compute - AvailabilitySets
2 participants