Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Modules] Updated Virtual Machine Module to latest API Version (2022-11-01) #3032

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

ahmadabdalla
Copy link
Contributor

Closes #3015

Description

Updated to latest API version

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute - VirtualMachines

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Mar 21, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.10.0 milestone Mar 21, 2023
@ahmadabdalla ahmadabdalla self-assigned this Mar 21, 2023
@github-actions
Copy link

github-actions bot commented Mar 21, 2023

Test Results

    1 files  ±  0      1 suites  ±0   1m 5s ⏱️ +17s
  88 tests +  4    86 ✔️ +  4  2 💤 ±0  0 ±0 
112 runs  +12  104 ✔️ +10  8 💤 +2  0 ±0 

Results for commit 83735c0. ± Comparison against base commit f8fa773.

This pull request removes 84 and adds 88 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachineScaleSets/extensions] used resource type [virtualMachineScaleSets/extensions] should use one of the recent API version(s). Currently using [2022-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachineScaleSets] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachineScaleSets] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachineScaleSets] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachineScaleSets] used resource type [virtualMachineScaleSets/extensions] should use one of the recent API version(s). Currently using [2022-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachineScaleSets] used resource type [virtualMachineScaleSets] should use one of the recent API version(s). Currently using [2022-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/virtualMachineScaleSets/extensions] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/virtualMachineScaleSets/extensions] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/virtualMachineScaleSets/extensions] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/virtualMachineScaleSets/extensions] All required parameters in template file (deploy.json) should exist in parameters files
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines/extensions] used resource type [virtualMachines/extensions] should use one of the recent API version(s). Currently using [2022-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines] used resource type [configurationProfileAssignments] should use one of the recent API version(s). Currently using [2021-04-30-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines] used resource type [networkInterfaces] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines] used resource type [publicIPAddresses] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines] used resource type [vaults/backupFabrics/protectionContainers/protectedItems] should use one of the recent API version(s). Currently using [2023-01-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines] used resource type [virtualMachines/extensions] should use one of the recent API version(s). Currently using [2022-11-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Compute/virtualMachines] used resource type [virtualMachines] should use one of the recent API version(s). Currently using [2022-11-01]
…
This pull request removes 2 skipped tests and adds 2 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/virtualMachineScaleSets/extensions] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Compute/virtualMachineScaleSets] JSON test files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Compute/virtualMachines/extensions] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Compute/virtualMachines] JSON test files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

@ahmadabdalla
Copy link
Contributor Author

Blocked by #3034

@ahmadabdalla ahmadabdalla marked this pull request as ready for review March 21, 2023 20:38
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner March 21, 2023 20:38
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) March 22, 2023 04:58
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ahmadabdalla ahmadabdalla merged commit e0641f6 into main Mar 22, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/3015_vmExt branch March 22, 2023 17:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] Compute - VirtualMachines
2 participants