Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Modules] Updated VMSS Module to the latest API Version (2022-11-01) #3033

Merged
merged 1 commit into from
Mar 21, 2023
Merged

[Modules] Updated VMSS Module to the latest API Version (2022-11-01) #3033

merged 1 commit into from
Mar 21, 2023

Conversation

ahmadabdalla
Copy link
Contributor

Closes #3021

Pipeline
Compute - VirtualMachineScaleSets

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Mar 21, 2023
@ahmadabdalla ahmadabdalla self-assigned this Mar 21, 2023
@ahmadabdalla ahmadabdalla force-pushed the users/ahmad/3021_vmss branch from 5f1c148 to 4282299 Compare March 21, 2023 07:12
@ahmadabdalla ahmadabdalla reopened this Mar 21, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review March 21, 2023 08:56
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner March 21, 2023 08:56
eriqua
eriqua approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ahmadabdalla ahmadabdalla merged commit f8fa773 into main Mar 21, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/3021_vmss branch March 21, 2023 10:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] Compute - VirtualMachineScaleSets
2 participants
@ahmadabdalla @eriqua