Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implemented private bicep registry publish #326

Merged
merged 34 commits into from
Nov 6, 2021

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 1, 2021

Change

  • Implemented private bicep registry publish
  • Added registry to dependency pipeline (including reference of artifacts-rg)
  • Added module usage example to docs
  • Streamlined pipeline parameter names
  • Aligned template spec module publish name with bicep registry
    • I.e. Instead of publishing 'servers' we now publish 'microsoft.sql.servers'

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr added this to the Public Preview milestone Nov 1, 2021
@AlexanderSehr AlexanderSehr added the enhancement New feature or request label Nov 1, 2021
@AlexanderSehr AlexanderSehr self-assigned this Nov 1, 2021
@AlexanderSehr AlexanderSehr marked this pull request as draft November 1, 2021 11:24
@AlexanderSehr AlexanderSehr linked an issue Nov 1, 2021 that may be closed by this pull request
@AlexanderSehr AlexanderSehr changed the base branch from main to dev November 2, 2021 23:01
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 2, 2021 23:02
@AlexanderSehr AlexanderSehr changed the base branch from dev to main November 3, 2021 21:59
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 5, 2021 18:05
@MariusStorhaug MariusStorhaug self-requested a review November 6, 2021 13:45
AlexanderSehr and others added 3 commits November 6, 2021 17:39
…ToPrivateBicepRegistry.ps1

Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
…ToPrivateBicepRegistry.ps1

Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all comments are fixed. Approved!

@AlexanderSehr AlexanderSehr merged commit 3f588d0 into main Nov 6, 2021
@MariusStorhaug MariusStorhaug deleted the users/alsehr/bicepReqistry branch November 6, 2021 18:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement private bicep registry publishing
3 participants