Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Modules] storage account module : conditional nfsv3 parameter #3290

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

Robbertbbb
Copy link
Contributor

@Robbertbbb Robbertbbb commented May 30, 2023

Description

This will fix #3106
only send the nfsv3 when enabled
cannot be changed or added with a value of False if the storage account wasn't creating with it.
this is fixing an breaking change

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Storage - StorageAccounts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@Robbertbbb Robbertbbb requested a review from a team as a code owner May 30, 2023 08:59
@Robbertbbb Robbertbbb changed the title made nfsv3 conditional Modules] storage account module : conditional nfsv3 parameter May 30, 2023
@Robbertbbb Robbertbbb changed the title Modules] storage account module : conditional nfsv3 parameter [Modules] storage account module : conditional nfsv3 parameter May 30, 2023
@Robbertbbb
Copy link
Contributor Author

this PR will replace:
#3122

@ahmadabdalla
Copy link
Contributor

@Robbertbbb thanks for your contribution and the new PR. Can you please attach a successful pipeline run for this change?

@Robbertbbb
Copy link
Contributor Author

Robbertbbb commented Jun 3, 2023 via email

@ahmadabdalla
Copy link
Contributor

@Robbertbbb I have tested the changes. Will be approving this PR:
Storage - StorageAccounts

Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
Storage - StorageAccounts

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants