Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Align RBAC on Microsoft.CognitiveServices #364

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Nov 3, 2021

Change

CognitiveServices: Accounts

  • Moved builtInRoleNames variable to .bicep/nested_rbac.json
  • Using declaration of existing resource + scope reference in roleAssignment resource declaration
  • Updated Readme

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Unit Test Results

  1 files  ±  0    1 suites  ±0   17s ⏱️ +4s
31 tests +27  31 ✔️ +27  0 💤 ±  0  0 ±0 
37 runs  +  2  31 ✔️ +27  6 💤  - 25  0 ±0 

Results for commit 515915d. ± Comparison against base commit c69e175.

This pull request removes 4 and adds 31 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DesktopVirtualization/hostpools] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2017-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DesktopVirtualization/hostpools] used resource type [hostPools] should use on of the recent API version(s). Currently using [2021-07-12]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DesktopVirtualization/hostpools] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.DesktopVirtualization/hostpools] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] All resources that have a Location property should refer to the Location parameter 'parameters('Location')'
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] If delete lock is implemented, the template should have a lock parameter with the default value of [NotSpecified]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] Parameter files should not contain subscriptionId original value and but a token string
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.CognitiveServices/accounts] Standard outputs should be provided (e.g. resourceName, resourceId, resouceGroupName)
…

♻️ This comment has been updated with latest results.

@MariusStorhaug MariusStorhaug merged commit 73240a6 into main Nov 3, 2021
@MariusStorhaug MariusStorhaug deleted the users/mast/MS.CognitiveServices_RBAC branch November 3, 2021 17:43
@MariusStorhaug MariusStorhaug linked an issue Nov 3, 2021 that may be closed by this pull request
@MariusStorhaug MariusStorhaug self-assigned this Nov 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move builtInRoleNames variable into rbac module
2 participants