Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Align RBAC on Microsoft.DocumentDB #379

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

MariusStorhaug
Copy link
Contributor

Change

  • Moved builtInRoleNames variable to .bicep/nested_rbac.json
  • Using declaration of existing resource + scope reference in roleAssignment resource declaration
  • Updated Readme

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug force-pushed the users/mast/MS.DocumentDB_RBAC branch from 53ea8a9 to 9ddcd2a Compare November 3, 2021 21:54
@MariusStorhaug MariusStorhaug merged commit 3c3487f into main Nov 3, 2021
@MariusStorhaug MariusStorhaug deleted the users/mast/MS.DocumentDB_RBAC branch November 3, 2021 22:03
@MariusStorhaug MariusStorhaug self-assigned this Nov 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants