Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Align RBAC on Microsoft.Management #388

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

MariusStorhaug
Copy link
Contributor

Change

  • Moved builtInRoleNames variable to .bicep/nested_rbac.json
  • Using declaration of existing resource + scope reference in roleAssignment resource declaration
  • Updated Readme

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug
Copy link
Contributor Author

This is a bit different than RG based RBAC deployments. Think we need to review and maybe rework this a bit.

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Unit Test Results

1 files  ±  0  0 suites   - 1   0s ⏱️ -17s
0 tests  - 31  0 ✔️  - 31  0 💤 ±0  0 ±0 
0 runs   - 37  0 ✔️  - 31  0 💤  - 6  0 ±0 

Results for commit 0bd053c. ± Comparison against base commit 688e6da.

This pull request removes 31 tests.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] All resources that have a Location property should refer to the Location parameter 'parameters('Location')'
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] If delete lock is implemented, the template should have a lock parameter with the default value of [NotSpecified]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] Parameter files should not contain subscriptionId original value and but a token string
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.DataFactory/factories] Standard outputs should be provided (e.g. resourceName, resourceId, resouceGroupName)
…

@MariusStorhaug MariusStorhaug self-assigned this Nov 4, 2021
@AlexanderSehr AlexanderSehr merged commit ae420ed into main Nov 4, 2021
@AlexanderSehr AlexanderSehr deleted the users/mast/MS.Management_RBAC branch November 4, 2021 10:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants