Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Users/torivara/virtual network gateways update #405

Merged

Conversation

torivara
Copy link
Contributor

@torivara torivara commented Nov 4, 2021

Change

Virtual Network Gateway with ExpressRoute type will not work if Public IP is set as zonal and gateway is set as regional. This means that the default settings will fail in some cases because PIP is zonal and gateway is not. Only tested with Express Route Gateway.

The proposed change is an update to the default value of publicIpZones and a conditional setting of zones on the automatically created pip.

Maybe this module should also support already existing pip-resources?

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Nov 6, 2021

Resolved a conflict for you

@AlexanderSehr AlexanderSehr added [cat] modules category: modules bug Something isn't working labels Nov 6, 2021
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes in + the merge from main, so all in good shape this time around. Approved.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants