Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Cleaned up compute modules & added output descriptions #421

Merged
merged 10 commits into from
Nov 6, 2021
Merged

Cleaned up compute modules & added output descriptions #421

merged 10 commits into from
Nov 6, 2021

Conversation

AlexanderSehr
Copy link
Contributor

Change

  • Cleaned up compute modules
    • Convert json(null) into null
    • Removed excess brackets
  • added output descriptions

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr added this to the v 0.3 milestone Nov 5, 2021
@AlexanderSehr AlexanderSehr linked an issue Nov 5, 2021 that may be closed by this pull request
Replace json('null') -> null across all modules #410
Closed
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Nov 5, 2021
@AlexanderSehr AlexanderSehr self-assigned this Nov 5, 2021
@AlexanderSehr AlexanderSehr added the enhancement New feature or request label Nov 5, 2021
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 5, 2021 20:21
@MariusStorhaug MariusStorhaug self-requested a review November 6, 2021 08:33
@MariusStorhaug MariusStorhaug removed a link to an issue Nov 6, 2021
Replace json('null') -> null across all modules #410
Closed
@MariusStorhaug
Copy link
Contributor

This PR is progress towards closing #410 and #238, but doesn't alone close it. So I am unlinking issues.

AlexanderSehr and others added 9 commits November 6, 2021 13:03
@AlexanderSehr
Update arm/Microsoft.Compute/virtualMachines/deploy.bicep
20b1c95 
Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Compute/virtualMachines/deploy.bicep
34bb0db 
Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Compute/virtualMachines/.bicep/nested_networkInt…
a1ac4cb 
…erface.bicep

Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Compute/virtualMachines/.bicep/nested_networkInt…
c442283 
…erface.bicep

Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Compute/virtualMachines/.bicep/nested_networkInt…
96b5a75 
…erface.bicep

Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Compute/virtualMachines/.bicep/nested_networkInt…
9c2c22c 
…erface.bicep

Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Compute/virtualMachines/.bicep/nested_networkInt…
0c06450 
…erface.bicep

Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Compute/virtualMachines/.bicep/nested_extension.…
611b45f 
…bicep

Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
@AlexanderSehr
Update arm/Microsoft.Compute/virtualMachines/deploy.bicep
34212ff 
Co-authored-by: Marius <Marius.Storhaug@microsoft.com>
@MariusStorhaug MariusStorhaug self-requested a review November 6, 2021 13:07
MariusStorhaug
MariusStorhaug approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments resolved. Fixes implemented. Approved.

@AlexanderSehr AlexanderSehr merged commit 55b4254 into main Nov 6, 2021
@MariusStorhaug MariusStorhaug deleted the users/alsehr/jsonNullCompute branch November 6, 2021 13:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
v 0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @MariusStorhaug