Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed unsupported default value #429

Merged
merged 3 commits into from
Nov 6, 2021
Merged

Conversation

AlexanderSehr
Copy link
Contributor

Change

  • Removed unsupported default value {{ ... }} from inputs of global validate job

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@github-actions
Copy link

github-actions bot commented Nov 6, 2021

Unit Test Results

  1 files  ±0  1 suites  ±0   16s ⏱️ -2s
  4 tests +1  4 ✔️ +1    0 💤 ±0  0 ±0 
35 runs  +1  4 ✔️ +1  31 💤 ±0  0 ±0 

Results for commit fafec23. ± Comparison against base commit 3f588d0.

This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationSecurityGroups] used resource type [applicationSecurityGroups] should use on of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationSecurityGroups] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationSecurityGroups] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2017-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [servers] should use on of the recent API version(s). Currently using [2017-08-01]

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 6, 2021 18:31
@AlexanderSehr AlexanderSehr added [cat] pipelines category: pipelines bug Something isn't working labels Nov 6, 2021
@AlexanderSehr AlexanderSehr self-assigned this Nov 6, 2021
@AlexanderSehr AlexanderSehr added this to the v 0.3 milestone Nov 6, 2021
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it!

@AlexanderSehr AlexanderSehr merged commit f07bb54 into main Nov 6, 2021
@MariusStorhaug MariusStorhaug deleted the users/alsehr/pipelineHotFix branch November 6, 2021 18:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working [cat] pipelines category: pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants