Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace json('null') -> null #464

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Replace json('null') -> null #464

merged 1 commit into from
Nov 12, 2021

Conversation

MariusStorhaug
Copy link
Contributor

Change

replace json('null') -> null

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug self-assigned this Nov 11, 2021
@MariusStorhaug MariusStorhaug linked an issue Nov 11, 2021 that may be closed by this pull request
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) November 11, 2021 15:11
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@MariusStorhaug MariusStorhaug merged commit b42f3a8 into main Nov 12, 2021
@MariusStorhaug MariusStorhaug deleted the users/mast/replaceNull branch November 12, 2021 07:57
@JulienFloris
Copy link
Contributor

JulienFloris commented Jul 26, 2022

@MariusStorhaug, Template are using both json('null') and null again.
like virtual network:

        natGateway: contains(subnet, 'natGatewayId') ? {
          'id': subnet.natGatewayId
        } : json('null')
        networkSecurityGroup: contains(subnet, 'networkSecurityGroupId') ? {
          'id': subnet.networkSecurityGroupId
        } : json('null')
        privateEndpointNetworkPolicies: contains(subnet, 'privateEndpointNetworkPolicies') ? subnet.privateEndpointNetworkPolicies : null
        privateLinkServiceNetworkPolicies: contains(subnet, 'privateLinkServiceNetworkPolicies') ? subnet.privateLinkServiceNetworkPolicies : null
        routeTable: contains(subnet, 'routeTableId') ? {
          'id': subnet.routeTableId
        } : json('null')

Could this be added to an quality test case and fixed? Or could/should i be a contributor?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace json('null') -> null across all modules
3 participants