Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated ACR name + added min param file #827

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

AlexanderSehr
Copy link
Contributor

Change

  • Updated ACR name as previous was taken (and probably too generic)
  • Added min parameter file too
    • Added reference to both GH & ADO pipelines

Pipeline reference
ContainerRegistry: Registries

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Dec 20, 2021
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Dec 20, 2021
@AlexanderSehr AlexanderSehr linked an issue Dec 20, 2021 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Dec 20, 2021

Unit Test Results

  1 files  ±  0  1 suites  ±0   25s ⏱️ -2s
  6 tests  -   3  6 ✔️  - 3    0 💤 ±  0  0 ±0 
38 runs   - 35  6 ✔️  - 3  32 💤  - 32  0 ±0 

Results for commit 527d5d3. ± Comparison against base commit bcb9f9f.

This pull request removes 9 and adds 6 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines/extensions] used resource type [virtualMachines/extensions] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [networkInterfaces] should use on of the recent API version(s). Currently using [2021-03-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [publicIPAddresses] should use on of the recent API version(s). Currently using [2021-03-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [vaults/backupFabrics/protectionContainers/protectedItems] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [virtualMachines/extensions] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/virtualMachines] used resource type [virtualMachines] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [privateEndpoints/privateDnsZoneGroups] should use on of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [privateEndpoints] should use on of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [registries] should use on of the recent API version(s). Currently using [2020-11-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ContainerRegistry/registries] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 20, 2021 19:14
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 55ae5ed into main Dec 20, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/containerReg branch December 22, 2021 09:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACR deployment fails with duplicated name
2 participants