Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix proximityPlacementGroup bug #950

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

simonbMS
Copy link
Contributor

@simonbMS simonbMS commented Feb 1, 2022

Change

Bugfix availability set when providing the proximityPlacementGroup parameter

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Unit Test Results

  1 files  ±  0  1 suites  ±0   17s ⏱️ -11s
  3 tests  -   2  3 ✔️  - 2    0 💤 ±  0  0 ±0 
35 runs   - 35  3 ✔️  - 2  32 💤  - 33  0 ±0 

Results for commit b6a39a2. ± Comparison against base commit 61d6f26.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceFabric/clusters/applicationTypes] used resource type [clusters/applicationTypes] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceFabric/clusters] used resource type [clusters/applicationTypes] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceFabric/clusters] used resource type [clusters] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceFabric/clusters] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceFabric/clusters] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/availabilitySets] used resource type [availabilitySets] should use on of the recent API version(s). Currently using [2021-07-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/availabilitySets] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Compute/availabilitySets] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]

♻️ This comment has been updated with latest results.

@simonbMS simonbMS added this to the v 0.5 milestone Feb 1, 2022
@simonbMS simonbMS added the bug Something isn't working label Feb 1, 2022
@simonbMS simonbMS self-assigned this Feb 1, 2022
@simonbMS simonbMS enabled auto-merge (squash) February 1, 2022 12:46
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@simonbMS simonbMS merged commit 95e0273 into main Feb 1, 2022
@simonbMS simonbMS deleted the users/simonb/949_availability_set_bugfix branch February 1, 2022 13:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Availability set not working if specifying proximityPlacementGroup
2 participants