-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[RDBMS] az postgres flexible-server update
: Add user confirmation on certain update operations
#30731
base: dev
Are you sure you want to change the base?
[RDBMS] az postgres flexible-server update
: Add user confirmation on certain update operations
#30731
Conversation
…certain update operations
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the suggested change to the comment, it looks good to me
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py
Outdated
Show resolved
Hide resolved
az postgres flexible-server update
: add user confirmation on certain update operationsaz postgres flexible-server update
: Add user confirmation on certain update operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We can't merge this PR until next breaking change window (Build release) |
Related command
az postgres flexible-server update
Description
Add user confirmation on certain update operations:
storage_gb
andinstance.storage.type
== "PremiumV2_LRS" andinstance.storage.storage_size_gb
!=storage_gb
sku_name
andinstance.sku.name
!=sku_name
storage_gb
andinstance.storage.type
== "" andstorage_gb
> 4096 andinstance.storage.storage_size_gb
<= 4096Testing Guide
Manual testing
History Notes
[RDBMS] BREAKING CHANGE:
az postgres flexible-server update
: Add user confirmation on certain update operationsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.