{Core} Add deviceId in CLI telemetry to share with VS code #30803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
requested review from
jiasli,
jsntcy,
kairu-ms,
zhoxing-ms,
calvinhzy,
necusjz and
bebound
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
pieandcakes
reviewed
Feb 14, 2025
| @@ -158,6 +158,7 @@ def _get_base_properties(self): | |||
| 'Context.Default.VS.Core.Distro.Id': _get_distro_id(), # eg. 'centos' | |||
| 'Context.Default.VS.Core.Distro.Version': _get_distro_version(), # eg. '8.4.2105' | |||
| 'Context.Dafault.VS.Core.Istty': str(sys.stdin.isatty()), | |||
| 'Context.Default.VS.Core.User.DeviceId': _get_device_id(), | |||
There was a problem hiding this comment.
If you wish to align with VS to make queries easier, our property is context.default.vs.core.devdeviceid
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
We want a shared deviceId in the telemetry to join CLI telemetry and VS code telemetry. VS code provides https://pypi.org/project/py-deviceid/ lib to generate the same device id for each device which can be used by VS code and CLI (or any other client tools)
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.