Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DNM] Adding support for Private DNS Public Preview #5763

Merged
merged 9 commits into from
Mar 15, 2018

Conversation

muwaqar
Copy link
Contributor

@muwaqar muwaqar commented Mar 8, 2018

This PR is a continuation of #5757 which accidentally got closed.

This PR adds support for creating/updating Private DNS zones for the public preview release. It is based on the Python SDK PR Azure/azure-sdk-for-net#4109 which in turn is based on Swagger version 2018-03-01-preview Azure/azure-rest-api-specs#2587.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@muwaqar muwaqar requested a review from tjprescott March 8, 2018 21:54
@promptws
Copy link

promptws commented Mar 8, 2018

View a preview at https://prompt.ws/r/Azure/azure-cli/5763
This is an experimental preview for @microsoft users.

@muwaqar
Copy link
Contributor Author

muwaqar commented Mar 8, 2018

Please do NOT merge the PR until the relevant Swagger and Python SDK PRs have been merged.

@tjprescott tjprescott added this to the Sprint 34 milestone Mar 8, 2018
@tjprescott tjprescott added Network az network vnet/lb/nic/dns/etc... Feature do-not-merge labels Mar 8, 2018
@tjprescott tjprescott changed the title Adding support for Private DNS Public Preview [DNM] Adding support for Private DNS Public Preview Mar 8, 2018
@muwaqar
Copy link
Contributor Author

muwaqar commented Mar 15, 2018

@tjprescott : Please have a look at the PR, and if you don't have any comments, then please merge it at your earliest convenience.

@tjprescott
Copy link
Member

LGTM

@tjprescott tjprescott merged commit 1138758 into Azure:dev Mar 15, 2018
@haroldrandom haroldrandom added Feature Network az network vnet/lb/nic/dns/etc... labels Oct 25, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Network az network vnet/lb/nic/dns/etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants