Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bicep/terraform starters containing azure-dev.yml workflow files #4344

Open
weikanglim opened this issue Sep 18, 2024 · 5 comments · May be fixed by #4412
Open

bicep/terraform starters containing azure-dev.yml workflow files #4344

weikanglim opened this issue Sep 18, 2024 · 5 comments · May be fixed by #4412
Assignees
Labels
golden-path Improvements to the getting started experience + golden path (local dev -> first deploy)
Milestone

Comments

@weikanglim
Copy link
Contributor

With #4013 landed, should we remove workflows from the starters (i.e. bicep starter, terraform starter) that don't have application code in them? They should look exactly the same as what azd pipeline config would generate when it runs (we should verify if it doesn't match).

The template repositories:

There are four files under the templates/common directory I believe that could be removed with this change.

@weikanglim weikanglim added the golden-path Improvements to the getting started experience + golden path (local dev -> first deploy) label Sep 18, 2024
@weikanglim
Copy link
Contributor Author

@jongio if this makes sense to you.

@v-xuto
Copy link
Member

v-xuto commented Sep 19, 2024

@rajeshkamal5050 Regarding Wei's comment above, should we wait for Jon's feedback, or should we directly submit a PR for this issue?

@rajeshkamal5050
Copy link
Contributor

@jongio can remove the static workflow files gives its part of azd pipeline?

@rajeshkamal5050
Copy link
Contributor

@v-xuto can you put out a PR for this?

@v-xuto
Copy link
Member

v-xuto commented Oct 8, 2024

@v-xuto can you put out a PR for this?

@rajeshkamal5050 PR is ready, please review.

@rajeshkamal5050 rajeshkamal5050 modified the milestones: Oct 2024, On Deck Oct 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
golden-path Improvements to the getting started experience + golden path (local dev -> first deploy)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants