Skip to content

Removed name property from update command #1206

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2021
Merged

Removed name property from update command #1206

merged 5 commits into from
Sep 17, 2021

Conversation

roshan-sy
Copy link
Contributor

@roshan-sy roshan-sy commented Sep 16, 2021 •
edited
Loading

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

  • : This PR has a corresponding issue open in the Repository.
  • : Approach is signed off on the issue.

Edit
Fixes: #1136

Changes:

  1. Removed name property from update command As its deprecated from the API side

@roshan-sy roshan-sy marked this pull request as ready for review September 17, 2021 06:04
@roshan-sy roshan-sy changed the title Fixed Removed name property from update command Sep 17, 2021
gauravsaralMs
gauravsaralMs reviewed Sep 17, 2021
View reviewed changes
gauravsaralMs
gauravsaralMs approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@gauravsaralMs gauravsaralMs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a note to call out this as a breaking change in next release

@roshan-sy can you create a issue to track next release and put the note there?

@roshan-sy roshan-sy merged commit c5df216 into master Sep 17, 2021
@roshan-sy roshan-sy deleted the Users/Roshan/1136 branch September 17, 2021 07:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
1 more reviewer

@gauravsaralMs gauravsaralMs gauravsaralMs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'GetDefinitionsResponseValue' has no len() on pipelines update
2 participants
@roshan-sy @gauravsaralMs