-
Notifications
You must be signed in to change notification settings - Fork 62
Upgrade GRPC to 1.29.0 #370
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Hey @TsuyoshiUshio, Thank you so much for working on this issue. Also can we please upgrade all the grps dependencies? Thank you so much for your help. |
7436adf
to
a9e9aa3
Compare
a9e9aa3
to
efe87c1
Compare
@amamounelsayed I've done the change version and rebase the commit log. |
I think now we are ready to merge. I did a research for grpc releases. Overall this change will cause these dependency change and some breaking change. However, customer can specify a specific version on Function App. So I think it is ready to merge.
|
Can you be more specific about breaking changes? code samples? Also, we should not move to production with breaking changes on minor version releases. |
@pragnagopa We update grpc-netty from 1.20.0 to 1.29.0. I'ld like to share the overview of it. Breaking change from grpc-netty 1.20 to 1.29API or Behavior changegRPCLB policy seelection: behavioral change. Updated dependencyntty 4.1.48.Final |
We need more specific code samples for before and after. Please https://github.com/Azure/app-service-announcements/issues?q=is%3Aissue++breaking+java for examples on previous breaking change announcements. Also, we should avoid breaking changes even though the gRpc itself has breaking changes in the link you mentioned. |
@prabgupta |
Thanks! Looking at the code sample will help you/@amamounelsayed determine the impact and decide if this change needs to be reverted. |
@pragnagopa |
A breaking change in a dependency would be considered a breaking change for customers. Please verify if that is the case as dependencies in Java worker take precedence over user dependencies. |
Sure. Good point. I'll do it. |
Hi @pragnagopa |
I create this PR for having a conversation.
I update the version of the grpc-netty from 1.20.0 to grpc-netty-shaded 1.29.0.
It passes the all local test. I'd like to have CI validation on this repo.
I change the interface of the
usePlainText(bool)
. It is deprecated for the new version.I'll investigate which library should be updated to latest.
Related issue
#365
#354