-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Better Dynamic converter #78
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 47.20% 48.04% +0.83%
==========================================
Files 39 39
Lines 4226 4196 -30
==========================================
+ Hits 1995 2016 +21
+ Misses 2086 2032 -54
- Partials 145 148 +3
Continue to review full report at Codecov.
|
Great job! I hope you won't mind that I did some work on the tests - modernized them and added negative tests. |
Unit Test Results 1 files ± 0 13 suites ±0 9s ⏱️ - 11m 42s Results for commit 98c6e81. ± Comparison against base commit 75e351f. This pull request removes 27 and adds 42 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
@AsafMah Thanks! |
Pull Request Description
This PR improves the conversion of Dynamic into different types of values. Major changes includes:
Future Release Comment
[Add description of your change, to include in the next release]
[Delete any or all irrelevant sections, e.g. if your change does not warrant a release comment at all]
Fixes: