Cache CosmosClient by account name #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [bug-fix] validate creation of CosmosClient upon creation so the auth key method actually gets triggered.
alexdrenea
requested review from
hallipr,
joshfree,
jongio,
g2vinay,
conniey,
xiangyan99 and
JonathanCrd
|
Thank you for your contribution @alexdrenea! We will review the pull request and get back to you soon. |
jongio
requested changes
May 6, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure MCP Server
xiangyan99
approved these changes
May 8, 2025
|
@alexdrenea we updated the interface of cache service to be public ValueTask SetAsync(string group, string key, T data, TimeSpan? expiration = null) Does this meet your requirements? If yes, could you rebase and update your PR? |
xiangyan99
added a commit
that referenced
this pull request
May 20, 2025
xiangyan99
added a commit
that referenced
this pull request
May 22, 2025
* Cache CosmosClient by account name #116 * update * update * update * update * update * update
|
Fixed in #231 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Caching for CosmosClient objects based on the requested account name (#102)
Also fixes a minor bug by validating the CosmosClient object upon creation so the auth key method actually gets re-triggered when credentials cannot be found.