Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Spring] Create New module Az.Spring and update Az.SpringCloud last version #23473

Closed
wants to merge 3 commits into from

Conversation

lijinpei2008
Copy link
Contributor

@lijinpei2008 lijinpei2008 commented Nov 17, 2023

Description

Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1360

Swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/appplatform/resource-manager/Microsoft.AppPlatform/stable/2022-04-01/appplatform.json

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Nov 17, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
❌Az.Spring
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
❌Test
❌ - Linux
❌ - MacOS
❌PowerShell Core - Windows
🔄Az.SpringCloud
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@lijinpei2008 lijinpei2008 deleted the jinpei/feature/spring branch January 2, 2024 08:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant