Update CMS Version to 1 for CodeSigningCIPolicySigning #26993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
Thank you for your contribution TechyDhaval! We will review the pull request and get back to you soon. |
Jaxelr
reviewed
Jan 10, 2025
| // Verify that the structure matches the expected pattern | ||
| if (signedData[i + 2 + sequenceLength] == cmsVersionTag && // tag for cmsVersion | ||
| signedData[i + 3 + sequenceLength] == cmsVersionLength && // CMS version value length | ||
| signedData[cmsVersionIndex] == cmsVersionV3) // Version is 3, needs to be updated |
There was a problem hiding this comment.
What happens if the cmsVersion is 1 instead of 3? From what I understand, it would throw an exception.
Perhaps its a better experience to just return the value unchanged?
TechyDhaval
force-pushed
the
dhjoshi/CMSVersionUpdate
branch
from
7ff9b7d to
a483492
Compare
|
@TechyDhaval LGTM. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.