Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Ping on April 8] Add properties in ADF ExecuteSSISPackage Activity #2716

Merged
merged 4 commits into from
Apr 4, 2018
Merged

[Ping on April 8] Add properties in ADF ExecuteSSISPackage Activity #2716

merged 4 commits into from
Apr 4, 2018

Conversation

qianwens
Copy link
Member

@qianwens qianwens commented Mar 21, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Mar 21, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#2293

@AutorestCI
Copy link

AutorestCI commented Mar 21, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
AutorestCI/azure-libraries-for-java#18

@AutorestCI
Copy link

AutorestCI commented Mar 21, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1502

@AutorestCI
Copy link

AutorestCI commented Mar 21, 2018

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#2500

@lmazuel
Copy link
Member

lmazuel commented Mar 22, 2018

@AutorestCI rebuild azure-sdk-for-python

@qianwens
Copy link
Member Author

Hi @hvermis This pull request has not been merged to master branch yet, is there anything other I need to do? Could you please help merge this pull request?

@hvermis
Copy link
Contributor

hvermis commented Mar 26, 2018

@qianwens Azure team manages this repo, not ADF. @mcardosos, are there any blocking issues for the PR?

Copy link
Contributor

@mcardosos mcardosos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
If you want to go the extra mile, I recommend to add this new properties to the example files.
For awareness, this service has some linter errors. I know they were not introduced in this PR.
One last question, are this changes already deployed in production regions?

@qianwens
Copy link
Member Author

@mcardosos The back-end changes will be deployed to production before 4/8. We plan to release this feature in April.

@mcardosos mcardosos added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 29, 2018
@mcardosos mcardosos changed the title Add properties in ADF ExecuteSSISPackage Activity [Ping on April 8] Add properties in ADF ExecuteSSISPackage Activity Mar 29, 2018
@mcardosos
Copy link
Contributor

Cool :D ping us when it is deployed :)

@qianwens
Copy link
Member Author

qianwens commented Mar 30, 2018 via email

@qianwens
Copy link
Member Author

qianwens commented Apr 4, 2018

@mcardosos we have deployed the back-end in first tier, please help merge this PR, thanks

@lmazuel
Copy link
Member

lmazuel commented Apr 6, 2018

@AutorestCI regenerate azure-sdk-for-python

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DoNotMerge <valid label in PR review process> use to hold merge after approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants