Add Management Groups 2018-03-01-preview version #3064
Conversation
AutoRest linter results for ARM Related Validation Errors/WarningsThese errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns. File: specification/managementgroups/resource-manager/readme.md
|
AutoRest linter results for SDK Related Validation Errors/WarningsThese errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns. File: specification/managementgroups/resource-manager/readme.md
|
| Code | Id | Source | Message |
|---|---|---|---|
| PostOperationIdContainsUrlVerb | R2066 | Link | OperationId should contain the verb: 'getentities' in:'Entities_List'. Consider updating the operationId |
| LongRunningOperationsWithLongRunningExtension | R2007 | Link | The operation 'StartTenantBackfill' returns 202 status code, which indicates a long running operation, please enable "x-ms-long-running-operation. |
❌0 new Errors.(0 total)
AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback
Thanks for your co-operation.
|
Thanks @rajshah11 - could you take a look at the model validation errors: |
annatisch
added
the
WaitForARMFeedback
|
@ravbhatnagar - looks like we have a new preview API for you to review :) |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-libraries-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
rajshah11
force-pushed
the
mgmt-groups-2018-preview
branch
from
025c1ca to
8ba3955
Compare
ravbhatnagar
added
ARMSignedOff
|
Looks good. |
| "in": "query", | ||
| "required": false, | ||
| "type": "string", | ||
| "description": "Page continuation token is only used if a previous operation returned a partial result. \nIf a previous response contains a nextLink element, the value of the nextLink element will include a token parameter that specifies a starting point to use for subsequent calls.\n", |
There was a problem hiding this comment.
Please remove newline from the end of descriptions.
| "info": { | ||
| "version": "2018-03-01-preview", | ||
| "title": "Management Groups API", | ||
| "description": "The Azure Management Groups API enables consolidation of multiple \nsubscriptions/resources into an organizational hierarchy and centrally \nmanage access control, policies, alerting and reporting for those resources.\n" |
There was a problem hiding this comment.
Please remove newline from the end of description.
| "tags": [ | ||
| { | ||
| "name": "ManagementGroups", | ||
| "description": "A Management Group is a customer defined scope (grouping mechanism) that \nprovides access control (authorization), policy management and reporting. \nManagement Groups are organized in a strictly tree-based hierarchy.\n" |
There was a problem hiding this comment.
Please remove newline from the end of description.
| }, | ||
| { | ||
| "name": "Operations", | ||
| "description": "Management operations supported by the Microsoft.Management resource provider.\n" |
There was a problem hiding this comment.
Please remove newline from the end of description.
| }, | ||
| { | ||
| "name": "Entities", | ||
| "description": "A list of entities that belong to the Management Groups.\n" |
There was a problem hiding this comment.
Please remove newline from the end of description.
| "delete" | ||
| ], | ||
| "description": "The id of the operation result.", | ||
| "x-ms-parameter-location": "client" |
There was a problem hiding this comment.
The parameter location needs to be "method"
| "schema": { | ||
| "$ref": "#/definitions/PatchManagementGroupRequest" | ||
| }, | ||
| "x-ms-parameter-location": "client" |
There was a problem hiding this comment.
The parameter location needs to be "method"
| "schema": { | ||
| "$ref": "#/definitions/CreateManagementGroupRequest" | ||
| }, | ||
| "x-ms-parameter-location": "client" |
There was a problem hiding this comment.
The parameter location needs to be "method"
| "required": false, | ||
| "type": "integer", | ||
| "description": "Number of elements to return when retrieving results. Passing this in will override $skipToken.", | ||
| "x-ms-parameter-location": "client" |
There was a problem hiding this comment.
The parameter location needs to be "method"
| "required": false, | ||
| "type": "string", | ||
| "description": "Page continuation token is only used if a previous operation returned a partial result. \nIf a previous response contains a nextLink element, the value of the nextLink element will include a token parameter that specifies a starting point to use for subsequent calls.\n", | ||
| "x-ms-parameter-location": "client" |
There was a problem hiding this comment.
The parameter location needs to be "method"
rajshah11
force-pushed
the
mgmt-groups-2018-preview
branch
from
9bcdff3 to
4f0f311
Compare
| "$ref": "./examples/GetEntities.json" | ||
| } | ||
| }, | ||
| "x-ms-long-running-operation": true |
There was a problem hiding this comment.
@rajshah11 - can you confirm that this list operation is indeed also a long running operation?
rajshah11
force-pushed
the
mgmt-groups-2018-preview
branch
from
2774e2f to
29f23e0
Compare
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger