Adding 2018-02-01 Traffic Manager API version.

[hrkulkarMsft]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2829

[AutorestCI]

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#137

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2038

[azuresdkciprbot]

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/trafficmanager/resource-manager/readme.md

⚠️0 new Warnings.(3 total)

❌0 new Errors.(5 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[azuresdkciprbot]

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/trafficmanager/resource-manager/readme.md

⚠️0 new Warnings.(1 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1842

[dsgouda]

@hrkulkarMsft why is this against the 2018-02 version? If this is a new API it should ideally be exposed in the latest versions (may/june)
@MikhailTryakhov can you take a look at this

[hrkulkarMsft]

@dsgouda we recently made a push to expose 2018-03-01 and forgot to take 2018-02-01 with it. Note, this would not break 2018-03-01 however due to the behavior of this field -- rather it would just be lacking it.

[MikhailTryakhov]

@dsgouda @hrkulkarMsft unfortunately February branch contribution is hold many months ago. Unfortunately we do not accept such tricks here.
Also no need to push changes dierctly in master - please use Network-2018-05-01 branch and 2018-05-01 branch only to push changes.
Details and scenarios are able by link

[dsgouda]

Thanks @MikhailTryakhov
This is a little confusing
@hrkulkarMsft does your RP have anything to do with Microsoft.Network? If yes, why is it under its own directory in the repo, if not, why is it named as trafficmanager\Microsoft.Network
We need to make sure the changes you are making here are valid.

[dsgouda]

Looks like most of the spec has already been reviewed in the 2018-03-01 version
The CI failures must be resolved before approval

[dsgouda]

@fearthecowboy Please confirm your approval for these suppressions

[fearthecowboy]

Yes, these suppressions are ok.

As far as I understand, they have things in the Microsoft.Network namespace, but it's still part of their RP. (we've got a couple cases of this elsewhere)

[azuresdkciprbot]

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/trafficmanager/resource-manager/readme.md

⚠️0 new Warnings.(3 total)

❌0 new Errors.(5 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[azuresdkciprbot]

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/trafficmanager/resource-manager/readme.md

⚠️0 new Warnings.(1 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[dsgouda]

LGTM