Managed instance data classification REST API - examples files name fixes #3673

igsiroti · 2018-08-20T12:58:55Z

No description provided.

…preview

azuresdkci · 2018-08-20T13:00:14Z

Can one of the admins verify this patch?

AutorestCI · 2018-08-20T13:00:31Z

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

AutorestCI · 2018-08-20T13:00:51Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1562

AutorestCI · 2018-08-20T13:01:31Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-08-20T13:04:28Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-08-20T13:14:16Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3483

annatisch · 2018-08-20T19:05:47Z

Thanks @igsiroti!
The changes look fine to me - however there are number of warnings in the breaking change CI that appear inconsistent with the diff in this PR.
Are you able to shed some light on these?

{
  "id": "1005",
  "code": "RemovedPath",
  "message": "The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/sensitivityLabels' removed or restructured?",
  "jsonref": "#/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Sql~1servers~1{serverName}~1databases~1{databaseName}~1sensitivityLabels",
  "json-path": "#/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/sensitivityLabels",
  "type": "Warning"
}

{
  "id": "1005",
  "code": "RemovedPath",
  "message": "The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/sensitivityLabels/{sensitivityLabelSource}' removed or restructured?",
  "jsonref": "#/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Sql~1servers~1{serverName}~1databases~1{databaseName}~1sensitivityLabels~1{sensitivityLabelSource}",
  "json-path": "#/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/sensitivityLabels/{sensitivityLabelSource}",
  "type": "Warning"
}

{
  "id": "1005",
  "code": "RemovedPath",
  "message": "The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/schemas/{schemaName}/tables/{tableName}/columns/{columnName}/sensitivityLabels/{sensitivityLabelSource}' removed or restructured?",
  "jsonref": "#/paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Sql~1servers~1{serverName}~1databases~1{databaseName}~1schemas~1{schemaName}~1tables~1{tableName}~1columns~1{columnName}~1sensitivityLabels~1{sensitivityLabelSource}",
  "json-path": "#/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/schemas/{schemaName}/tables/{tableName}/columns/{columnName}/sensitivityLabels/{sensitivityLabelSource}",
  "type": "Warning"
}

{
  "id": "1038",
  "code": "AddedPath",
  "message": "The new version is adding a path that was not found in the old version.",
  "jsonref": "#/paths/~1subscriptions~1{}~1resourceGroups~1{}~1providers~1Microsoft.Sql~1managedInstances~1{}~1databases~1{}~1schemas~1{}~1tables~1{}~1columns~1{}~1sensitivityLabels~1{}",
  "json-path": "#/paths/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/managedInstances/{}/databases/{}/schemas/{}/tables/{}/columns/{}/sensitivityLabels/{}",
  "type": "Info"
}

{
  "id": "1038",
  "code": "AddedPath",
  "message": "The new version is adding a path that was not found in the old version.",
  "jsonref": "#/paths/~1subscriptions~1{}~1resourceGroups~1{}~1providers~1Microsoft.Sql~1managedInstances~1{}~1databases~1{}~1sensitivityLabels",
  "json-path": "#/paths/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/managedInstances/{}/databases/{}/sensitivityLabels",
  "type": "Info"
}

{
  "id": "1038",
  "code": "AddedPath",
  "message": "The new version is adding a path that was not found in the old version.",
  "jsonref": "#/paths/~1subscriptions~1{}~1resourceGroups~1{}~1providers~1Microsoft.Sql~1managedInstances~1{}~1databases~1{}~1sensitivityLabels~1{}",
  "json-path": "#/paths/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/managedInstances/{}/databases/{}/sensitivityLabels/{}",
  "type": "Info"
}

{
  "id": "1007",
  "code": "RemovedClientParameter",
  "message": "The new version is missing a client parameter that was found in the old version. Was 'ServerNameParameter' removed or renamed?",
  "jsonref": "#/parameters",
  "json-path": "#/parameters",
  "type": "Warning"
}

igsiroti · 2018-08-20T19:37:32Z

Thanks @annatisch for the review! In the removed files there was a typo in their names '..Sensitivty...' instead of '..Sensitivity...' so I renamed them (it shows as if removed and added) and updated the refs. Does it makes sense?

annatisch · 2018-08-20T19:50:26Z

Thanks @igsiroti - yes I understand the changes in the PR.
My question was more regarding the warnings I printed in my last post - it's showing path changes, for example:
"#/paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/sensitivityLabels"
has been changed to:
"#/paths/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Sql/managedInstances/{}/databases/{}/sensitivityLabels"

And the serverName client parameter used in the original URL is no longer present.

Were these path changes recently introduced to the spec? Just trying to figure out where these warnings are coming from :)

…pecs

igsiroti · 2018-08-20T21:08:20Z

sorry my bad. adding it now

annatisch · 2018-08-21T21:02:22Z

Thanks @igsiroti - though I'm a bit confused - are these new changes to the API? Were they existing changes that were somehow reverted?

annatisch · 2018-08-21T21:52:54Z

Looking at the changes it appears that:

Some new breaking APIs that were added to sensitivityLabels.json have been reverted which resolves the breaking changes.
These new APIs have now been moved to managedInstanceSensitivityLabels.json and will coexist.

Does this sound accurate?
Can you confirm whether these new managedInstanceSensitivityLabels APIs have already received ARM signoff and if so could you please link to the PR?

Finally - are you aware that currently no SDKs are being generated for these new APIs? If you wish for them to be added to the SDK, please add the new spec to the package tag in the readme :)

Thanks!

igsiroti · 2018-08-25T06:10:08Z

That is correct
The APIs haven't received ARM signoff yet
Yes I'm aware of that

Thanks

annatisch · 2018-08-27T14:08:11Z

Thanks @igsiroti!
Adding @ravbhatnagar for ARM review.

annatisch · 2018-08-31T21:07:25Z

Ping @ravbhatnagar

Removed sensitivityLabelSource segment. Changed REST API to (in logical server and managed instance(: providers/Microsoft.Sql/managedInstances/{managedInstanceName}/databases/{databaseName}/sensitivityLabels /providers/Microsoft.Sql/managedInstances/{managedInstanceName}/databases/{databaseName}/currentSensitivityLabels providers/Microsoft.Sql/managedInstances/{managedInstanceName}/databases/{databaseName}/recommendedSensitivityLabels

annatisch · 2018-09-06T22:12:21Z

Pinging @ravbhatnagar again - could you please take a look at the new managed instance sensitivity label APIs?

ravbhatnagar · 2018-09-07T15:09:41Z

...ource-manager/Microsoft.Sql/preview/2018-06-01-preview/managedInstanceSensitivityLabels.json

+              "$ref": "#/definitions/SensitivityLabel"
+            }
+          },
+          "default": {


schema for the default response much be the ARM error contract as described in RPC. Check Batch RP swagger for a sample.

checked with Igal. He will follow up with Jared since all SQL swaggers are generated by tool.

...ource-manager/Microsoft.Sql/preview/2018-06-01-preview/managedInstanceSensitivityLabels.json

ravbhatnagar · 2018-09-07T18:00:15Z

@igsiroti FYI

annatisch · 2018-09-14T18:15:53Z

Thanks @ravbhatnagar
@igsiroti - what is the status of this PR?
Are you waiting on input from a 3rd party regarding the ARM error responses in the spec?

igsiroti · 2018-09-16T06:11:05Z

Correct. I want to make sure we are OK with the default response @ravbhatnagar mentioned above. Waiting for Jared's response

ravbhatnagar · 2018-09-17T21:21:16Z

Default response can be added later as it needs to be added to all SQL APIs. Signing off on this from ARM side.

annatisch · 2018-09-17T23:02:50Z

...ource-manager/Microsoft.Sql/preview/2018-06-01-preview/managedInstanceSensitivityLabels.json

+            "name": "sensitivityLabelSource",
+            "in": "path",
+            "description": "Optional source of the sensitivity label. Valid values are current or recommeneded. In not specified both returned.",
+            "required": true,


The description says this is optional, but it's marked as required.

Not sure how but it's old file. Fixing it

You're right - looks like I didn't have the latest changes :)

...ource-manager/Microsoft.Sql/preview/2018-06-01-preview/managedInstanceSensitivityLabels.json

AutorestCI · 2018-09-20T08:10:29Z

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

annatisch · 2018-09-20T21:16:33Z

Thanks @igsiroti - it's looking good.
Last thing - You changed the names of the operations to "ManagedDatabaseSensitivityLabels" yet the spec itself is still called "ManagedInstanceSensitivityLabels.json" - could this be renamed?

igsiroti · 2018-09-25T12:44:47Z

Thanks @annatisch. I renamed the spec

igsiroti added 9 commits August 12, 2018 16:26

Additional API to get current OR recommended labels (not both)

d126152

Managed instance sensetivity labels REST API - examples

510f12f

managed instance data classification REST API for version 2018-06-01-…

0554966

…preview

semantic fixes

3b37dfa

fixes after review

36c4ece

list labels with source - new API

9b326eb

fix example file name

87a4190

naming issues

4315de3

typo fixes

1e19468

azuresdkci assigned annatisch Aug 20, 2018

azuresdkci requested a review from annatisch August 20, 2018 12:59

Merge branch 'master' into master

c93c16c

igsiroti added 2 commits August 21, 2018 00:06

revert sensitivity labels API

394db1c

Merge branch 'master' of https://github.com/igsiroti/azure-rest-api-s…

d651c3d

…pecs

igsiroti added 4 commits August 21, 2018 00:43

syntax error fix

5e5e5b4

semantic fixes

6ee9f8e

semantic fixes

ac83a6e

semantic fixes

eeb6602

annatisch added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 27, 2018

annatisch requested a review from ravbhatnagar August 27, 2018 14:08

igsiroti closed this Sep 2, 2018

AutorestCI mentioned this pull request Sep 2, 2018

[AutoPR sql/resource-manager] Managed instance data classification REST API - examples files name fixes Azure/azure-sdk-for-node#3482

Closed

igsiroti reopened this Sep 4, 2018

AutorestCI mentioned this pull request Sep 4, 2018

[AutoPR sql/resource-manager] Managed instance data classification REST API - examples files name fixes Azure/azure-sdk-for-node#3483

Closed

sematic fix

f9ecf02

ravbhatnagar reviewed Sep 7, 2018

View reviewed changes

ravbhatnagar added the ARMReviewInProgress label Sep 7, 2018

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 17, 2018

annatisch reviewed Sep 17, 2018

View reviewed changes

AutorestCI mentioned this pull request Sep 20, 2018

[AutoPR sql/resource-manager] Managed instance data classification REST API - examples files name fixes Azure/azure-sdk-for-ruby#1676

Merged

Operation ID fixes

041edd1

spec rename

d88f017

annatisch approved these changes Sep 25, 2018

View reviewed changes

annatisch merged commit 57d827e into Azure:master Sep 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Managed instance data classification REST API - examples files name fixes #3673

Managed instance data classification REST API - examples files name fixes #3673

igsiroti commented Aug 20, 2018

azuresdkci commented Aug 20, 2018

AutorestCI commented Aug 20, 2018 •

edited

Loading

AutorestCI commented Aug 20, 2018 •

edited

Loading

AutorestCI commented Aug 20, 2018 •

edited

Loading

AutorestCI commented Aug 20, 2018 •

edited

Loading

AutorestCI commented Aug 20, 2018 •

edited

Loading

annatisch commented Aug 20, 2018

igsiroti commented Aug 20, 2018

annatisch commented Aug 20, 2018

igsiroti commented Aug 20, 2018

annatisch commented Aug 21, 2018

annatisch commented Aug 21, 2018

igsiroti commented Aug 25, 2018

annatisch commented Aug 27, 2018

annatisch commented Aug 31, 2018

annatisch commented Sep 6, 2018

ravbhatnagar Sep 7, 2018

ravbhatnagar Sep 12, 2018

ravbhatnagar commented Sep 7, 2018

annatisch commented Sep 14, 2018

igsiroti commented Sep 16, 2018

ravbhatnagar commented Sep 17, 2018

annatisch Sep 17, 2018

igsiroti Sep 20, 2018

annatisch Sep 20, 2018

AutorestCI commented Sep 20, 2018 •

edited

Loading

annatisch commented Sep 20, 2018 •

edited

Loading

igsiroti commented Sep 25, 2018

Managed instance data classification REST API - examples files name fixes #3673

Managed instance data classification REST API - examples files name fixes #3673

Conversation

igsiroti commented Aug 20, 2018

azuresdkci commented Aug 20, 2018

AutorestCI commented Aug 20, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Aug 20, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Aug 20, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Aug 20, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Aug 20, 2018 • edited Loading

Automation for azure-sdk-for-node

annatisch commented Aug 20, 2018

igsiroti commented Aug 20, 2018

annatisch commented Aug 20, 2018

igsiroti commented Aug 20, 2018

annatisch commented Aug 21, 2018

annatisch commented Aug 21, 2018

igsiroti commented Aug 25, 2018

annatisch commented Aug 27, 2018

annatisch commented Aug 31, 2018

annatisch commented Sep 6, 2018

ravbhatnagar Sep 7, 2018

Choose a reason for hiding this comment

ravbhatnagar Sep 12, 2018

Choose a reason for hiding this comment

ravbhatnagar commented Sep 7, 2018

annatisch commented Sep 14, 2018

igsiroti commented Sep 16, 2018

ravbhatnagar commented Sep 17, 2018

annatisch Sep 17, 2018

Choose a reason for hiding this comment

igsiroti Sep 20, 2018

Choose a reason for hiding this comment

annatisch Sep 20, 2018

Choose a reason for hiding this comment

AutorestCI commented Sep 20, 2018 • edited Loading

Automation for azure-sdk-for-js

annatisch commented Sep 20, 2018 • edited Loading

igsiroti commented Sep 25, 2018

AutorestCI commented Aug 20, 2018 •

edited

Loading

AutorestCI commented Aug 20, 2018 •

edited

Loading

AutorestCI commented Aug 20, 2018 •

edited

Loading

AutorestCI commented Aug 20, 2018 •

edited

Loading

AutorestCI commented Aug 20, 2018 •

edited

Loading

AutorestCI commented Sep 20, 2018 •

edited

Loading

annatisch commented Sep 20, 2018 •

edited

Loading