Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EventHub: moved VNet, IpFilter rules and Kafka from 2018-preview to 2017 API Version #4246

Merged
merged 1 commit into from
Oct 19, 2018
Merged

EventHub: moved VNet, IpFilter rules and Kafka from 2018-preview to 2017 API Version #4246

merged 1 commit into from
Oct 19, 2018

Conversation

v-Ajnava
Copy link
Member

approved PR for 2018-preview API Version : #3294

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3240

@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#257

@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3919

@azuresdkci azuresdkci requested a review from dsgouda October 16, 2018 21:31
@AutorestCI
Copy link

AutorestCI commented Oct 16, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3090

@AutorestCI AutorestCI mentioned this pull request Oct 16, 2018
Merged
@dsgouda
Copy link
Contributor

dsgouda commented Oct 16, 2018

@v-Ajnava could you create a commit of original files copied into this version before changes from the new version were introduced

@v-Ajnava
Copy link
Member Author

@dsgouda , we are moving the VNetRule, IPFilterRule and EnablleKafka from 2018-preview to 2017 API version. For 2018-Preview version the only .Net SDK was published with Version 2.8.0-preview. When publishing the new SDK for 2017 (stable) the current PR, we will bump the Major version which will be - 3.0.0

dsgouda
dsgouda suggested changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, please ensure PUT/DELETE operations are not long running

specification/eventhub/resource-manager/Microsoft.EventHub/stable/2017-04-01/EventHub.json
}
],
"responses": {
"200": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if this is a long running operation

Copy link
Member Author

@v-Ajnava v-Ajnava Oct 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda , PUT and DELETE for namespace are long running operations, do we need to change that ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this operation is for Namespace IPFilterRule, please check the same

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda ,I checked the swagger, only namespace PUT and DELETE are with "x-ms-long-running-operation": true.
The Namespace IPFilterRule dose not have '"x-ms-long-running-operation": true.'

dsgouda
dsgouda approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 8c6f982 into Azure:master Oct 19, 2018
v-Ajnava pushed a commit to v-Ajnava/azure-rest-api-specs that referenced this pull request Oct 24, 2018
Revert "moved VNet, IpFilter rules and Kafka from 2018-preview to 201…
d4da47b 
…7 API version (Azure#4246)"

This reverts commit 8c6f982.
@v-Ajnava v-Ajnava mentioned this pull request Oct 24, 2018
Merged
10 tasks
anuchandy pushed a commit that referenced this pull request Oct 26, 2018
@anuchandy
EventHub : Revert PR 4246 from 2017 and added Kafka enabled (#4321)
01eb8f2 
* Revert "moved VNet, IpFilter rules and Kafka from 2018-preview to 2017 API version (#4246)"

This reverts commit 8c6f982.

* some lint fix

* added kafkaEnabled to Namespace
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees

@dsgouda dsgouda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-Ajnava @azuresdkci @AutorestCI @dsgouda