-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add 2 missing endpoints to newest versions Microsoft.Logic #4332
Add 2 missing endpoints to newest versions Microsoft.Logic #4332
Conversation
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
@lmazuel Could I get some eyes on this? Also, What's is your guys' SLA? The link for it on the contributions page is dead. |
Hi @refortie |
@AutorestCI rebuild azure-sdk-for-java |
specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
Show resolved
Hide resolved
specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
Outdated
Show resolved
Hide resolved
specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
Outdated
Show resolved
Hide resolved
specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
Outdated
Show resolved
Hide resolved
specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
Outdated
Show resolved
Hide resolved
specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
Show resolved
Hide resolved
Hi @refortie |
Hi @lmazuel, So I must not understand this correctly, the model we provide in the workflow examples and such does exist. If you got to the page, it resolves with a 200 with the actual schema. Is that not correct? |
@sergey-shandar help on the "unresolved reference". Is this because the final # ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor note.
specification/logic/resource-manager/Microsoft.Logic/preview/2018-07-01-preview/logic.json
Show resolved
Hide resolved
Signing off from ARM side, just one minor note which needs to be fixed. |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger