Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add 2 missing endpoints to newest versions Microsoft.Logic #4332

Merged
merged 6 commits into from
Nov 15, 2018

Conversation

refortie
Copy link
Contributor

@refortie refortie commented Oct 25, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 25, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2311

@AutorestCI
Copy link

AutorestCI commented Oct 25, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#507

@AutorestCI
Copy link

AutorestCI commented Oct 25, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1914

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 25, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4111

@AutorestCI
Copy link

AutorestCI commented Oct 25, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2782

@AutorestCI
Copy link

AutorestCI commented Oct 25, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3311

@refortie
Copy link
Contributor Author

refortie commented Nov 1, 2018

@lmazuel Could I get some eyes on this? Also, What's is your guys' SLA? The link for it on the contributions page is dead.

@lmazuel
Copy link
Member

lmazuel commented Nov 5, 2018

Hi @refortie
Sorry for the late review, I thought I could keep up with review last week, but I should have reassigned it and assume time will be missing :(
Looking at it right now.
Thanks you

@lmazuel lmazuel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 5, 2018
@lmazuel
Copy link
Member

lmazuel commented Nov 5, 2018

@AutorestCI rebuild azure-sdk-for-java

@lmazuel
Copy link
Member

lmazuel commented Nov 5, 2018

Hi @refortie
There is important model validation issue. I know most of them are not introduced in your PR, but would be nice if you can try to understand and tell your team. "unresolved reference" will likely create invalid SDK.

@refortie
Copy link
Contributor Author

refortie commented Nov 5, 2018

Hi @lmazuel,

So I must not understand this correctly, the model we provide in the workflow examples and such does exist. If you got to the page, it resolves with a 200 with the actual schema. Is that not correct?

@lmazuel
Copy link
Member

lmazuel commented Nov 5, 2018

@sergey-shandar help on the "unresolved reference". Is this because the final # ?

Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor note.

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side, just one minor note which needs to be fixed.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 5, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants