Add playbook configurations resource REST specification #5548

mikreite · 2019-04-04T15:20:41Z

I'd like to add the DoNotMerge label, but the UI would not allow me to do so.
Please advise.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-04-04T15:21:16Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmp29h_bl4n/rest/specification/security/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp5wkefzpz']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-04-04T15:21:41Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 708dfce51dce754fa6caa8dad1aed21e4ee80232
  stderr: 'fatal: reference is not a tree: 708dfce51dce754fa6caa8dad1aed21e4ee80232'

AutorestCI · 2019-04-04T15:22:07Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-04-04T15:22:10Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#2840

AutorestCI · 2019-04-04T15:23:43Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 708dfce51dce754fa6caa8dad1aed21e4ee80232
  stderr: 'fatal: reference is not a tree: 708dfce51dce754fa6caa8dad1aed21e4ee80232'

REST Spec PR 'Azure/azure-rest-api-specs#5548' REST Spec PR Author 'mikreite' REST Spec PR Last commit

azuresdkci · 2019-04-04T15:30:58Z

Can one of the admins verify this patch?

praries880 · 2019-04-05T21:07:47Z

@mikreite Kindly ping me when this PR is ready to review.

...y/resource-manager/Microsoft.Security/preview/2019-01-01-preview/playbookConfigurations.json

...1-preview/examples/PlaybookConfigurations/GetPlaybookConfigurationResourceGroup_example.json

...y/resource-manager/Microsoft.Security/preview/2019-01-01-preview/playbookConfigurations.json

introduce trackedResource entity

REST Spec PR 'Azure/azure-rest-api-specs#5548' REST Spec PR Author 'mikreite' REST Spec PR Last commit

mikreite · 2019-04-18T15:11:57Z

Hi @praries880, the PR is ready to review

praries880 · 2019-04-18T19:21:18Z

@mikreite kindly take care of the merge conflict

dafishma · 2019-05-14T05:25:28Z

@majastrz can you please confirm that all comments were addressed please?
Are we good to go?

jhendrixMSFT · 2019-05-28T16:50:21Z

@AutorestCI regenerate azure-sdk-for-go

praries880 · 2019-07-01T18:23:23Z

@mikreite Is the PR ready to merge now? Also, kindly take care of the merge conflict

praries880 · 2019-07-08T18:00:46Z

@mikreite pinging back

dafishma · 2019-07-08T18:23:52Z

Hi, The PR cannot be merged yet. We are still in a preview phase to check this. Will update when it is ready to complete. Thanks, David Fishman From: Pareekshit Singh <notifications@github.com> Sent: Monday, July 1, 2019 9:24 PM To: Azure/azure-rest-api-specs <azure-rest-api-specs@noreply.github.com> Cc: David Fishman <dafishma@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/azure-rest-api-specs] Add playbook configurations resource REST specification (#5548) @mikreite<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.heygears.com%2Fmikreite&data=02%7C01%7Cdafishma%40microsoft.com%7C08b62f7cb26e46c8fef308d6fe51438f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636976022311942883&sdata=47A07NLUcZWzv%2BcxWFXPqOlWp94MUFLit6sqPYGMm00%3D&reserved=0> Is the PR ready to merge now? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.heygears.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F5548%3Femail_source%3Dnotifications%26email_token%3DAL4WNRJZ4W4YJYLNAB45QWLP5JDTLA5CNFSM4HDUI7F2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY66JTY%23issuecomment-507372751&data=02%7C01%7Cdafishma%40microsoft.com%7C08b62f7cb26e46c8fef308d6fe51438f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636976022311942883&sdata=tqQ8Rh6spKAA%2BJsLbex6dZtBM9%2FGBS4z4PRK8fUCA6E%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.heygears.com%2Fnotifications%2Funsubscribe-auth%2FAL4WNRNNRLLPBT3AZ3WBHL3P5JDTLANCNFSM4HDUI7FQ&data=02%7C01%7Cdafishma%40microsoft.com%7C08b62f7cb26e46c8fef308d6fe51438f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636976022311952893&sdata=pKWbHxZw3P5rIKXvHi%2F4jOf6jolB9GyCUZXL6%2FasKE0%3D&reserved=0>.

erich-wang · 2019-08-06T04:54:21Z

@mikreite , could you address change requests from @chlahav ? Please let us know if the PR is ready for merge.

mikreite · 2019-08-06T06:48:14Z

@erich-wang thanks for your reminder. There are still changes to be made, we are still not ready for merge. ETA for handling them by the next 2-3 weeks.

yungezz · 2019-08-15T01:41:58Z

Hi @mikreite is it ok to close the PR now since you're not ready for merge now, and it's over 4 months, there's conflict already with latest code base. pls create new PR when you're ready for merge.

mikreite · 2019-08-15T13:57:11Z

Hi @yungezz this resource is part of a private preview feature that is exposed in our RP manifest. We have approved the manifest change by having this open PR. This feature is going to be public (preview) by end of Sep. so the PR is supposed to be merged soon. Regarding the conflicts - I'll update the PR on a weekly basis, until last finishes are done. Please let me know if we should act differently, thanks.

yungezz · 2019-08-16T06:05:14Z

@mikreite it's ok if the PR is still active.

openapi-sdkautomation · 2019-08-25T10:57:42Z

In Testing, Please Ignore

[Logs] (Generated from 6728524, Iteration 3)

.NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]

Microsoft.Azure.Management.SecurityCenter [Logs] [Instructions] [Generation PR]
- Microsoft.Azure.Management.SecurityCenter.1.0.1.nupkg
- Microsoft.Azure.Management.SecurityCenter.1.0.1.snupkg

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/security/mgmt/v1.0 [Logs]
preview/security/mgmt/v2.0 [Logs]
preview/security/mgmt/v3.0 [Logs]

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-security [Logs] [Instructions] [Generation PR]
- azure-mgmt-security-0.3.0.zip
- azure_mgmt_security-0.3.0-py2.py3-none-any.whl

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/arm-security [Logs] [Instructions]
- azure-arm-security-1.2.0.tgz

* Adding SCVMM VM prop - limitCPUForMigration * liniting error fix Co-authored-by: Siddhant Singh <siddhant9868@gmail.com>

add playbook configurations resource REST specification

daa2f3b

AutorestCI mentioned this pull request Apr 4, 2019

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-python#4778

Closed

AutorestCI mentioned this pull request Apr 4, 2019

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-js#2015

Closed

azuresdkci assigned praries880 Apr 4, 2019

azuresdkci requested a review from praries880 April 4, 2019 15:22

AutorestCI mentioned this pull request Apr 4, 2019

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-go#4479

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 4, 2019

.NET SDK Resource Provider:'SecurityCenter'

6054083

REST Spec PR 'Azure/azure-rest-api-specs#5548' REST Spec PR Author 'mikreite' REST Spec PR Last commit

chlahav self-requested a review April 4, 2019 15:44

chlahav added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 4, 2019

chlahav requested changes Apr 8, 2019

View reviewed changes

fix according to PR comments + some spec changes

9e0ae57

introduce trackedResource entity

AutorestCI mentioned this pull request Apr 14, 2019

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-js#2246

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 14, 2019

.NET SDK Resource Provider:'SecurityCenter'

7b32153

REST Spec PR 'Azure/azure-rest-api-specs#5548' REST Spec PR Author 'mikreite' REST Spec PR Last commit

add propertyType and operator enums

29ac581

dsgouda mentioned this pull request Apr 15, 2019

AutoPr-SecurityCenter-mikreite-REST Spec PrNumber 5548 Azure/azure-sdk-for-net#5793

Closed

mikreite marked this pull request as ready for review April 18, 2019 15:10

chlahav added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 18, 2019

praries880 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 18, 2019

merge from upstream/master

395f014

This was referenced Apr 21, 2019

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-python#4919

Closed

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-js#2384

Closed

AutorestCI mentioned this pull request May 12, 2019

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-js#2840

Closed

Adding descriminator and updating examples

a08ee83

majastrz approved these changes May 14, 2019

View reviewed changes

AutorestCI mentioned this pull request May 28, 2019

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-go#4881

Closed

yungezz assigned erich-wang and unassigned praries880 Aug 6, 2019

Adding event hub action to playbook RP

7c02e45

This was referenced Aug 25, 2019

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-python#6934

Closed

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-go#5609

Closed

mikreite and others added 2 commits August 25, 2019 14:50

merge from upstream/master

1ef02d3

adding securityEmail action type

6728524

This was referenced Sep 26, 2019

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-python#7449

Closed

[AutoPR security/resource-manager] Add playbook configurations resource REST specification Azure/azure-sdk-for-go#5891

Closed

openapi-sdkautomation bot mentioned this pull request Sep 26, 2019

[AutoPR Microsoft.Azure.Management.SecurityCenter] Add playbook configurations resource REST specification test-repo-billy/azure-sdk-for-net#243

Closed

mikreite closed this Oct 30, 2019

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Adding SCVMM VM prop - limitCPUForMigration (#5548)

393538c

* Adding SCVMM VM prop - limitCPUForMigration * liniting error fix Co-authored-by: Siddhant Singh <siddhant9868@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add playbook configurations resource REST specification #5548

Add playbook configurations resource REST specification #5548

mikreite commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

azuresdkci commented Apr 4, 2019

praries880 commented Apr 5, 2019

mikreite commented Apr 18, 2019

praries880 commented Apr 18, 2019

dafishma commented May 14, 2019

jhendrixMSFT commented May 28, 2019

praries880 commented Jul 1, 2019 •

edited

Loading

praries880 commented Jul 8, 2019

dafishma commented Jul 8, 2019 via email

erich-wang commented Aug 6, 2019

mikreite commented Aug 6, 2019

yungezz commented Aug 15, 2019

mikreite commented Aug 15, 2019

yungezz commented Aug 16, 2019

openapi-sdkautomation bot commented Aug 25, 2019 •

edited

Loading

Add playbook configurations resource REST specification #5548

Add playbook configurations resource REST specification #5548

Conversation

mikreite commented Apr 4, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Apr 4, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Apr 4, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 4, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Apr 4, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Apr 4, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Apr 4, 2019

praries880 commented Apr 5, 2019

mikreite commented Apr 18, 2019

praries880 commented Apr 18, 2019

dafishma commented May 14, 2019

jhendrixMSFT commented May 28, 2019

praries880 commented Jul 1, 2019 • edited Loading

praries880 commented Jul 8, 2019

dafishma commented Jul 8, 2019 via email

erich-wang commented Aug 6, 2019

mikreite commented Aug 6, 2019

yungezz commented Aug 15, 2019

mikreite commented Aug 15, 2019

yungezz commented Aug 16, 2019

openapi-sdkautomation bot commented Aug 25, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 6728524, Iteration 3)

mikreite commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

AutorestCI commented Apr 4, 2019 •

edited

Loading

praries880 commented Jul 1, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 25, 2019 •

edited

Loading