Additional Bug Fixes when Internet is not available #44
Conversation
When the ESP32 disconnects from WiFi and then reconnects, it gets stuck in an infinite azure reconnecting loop
The bug fix that was previously applied to the Azure_IoT_Central_ESP32.ino file where the connecting process to Azure IoT Central gets stuck in an infinite connecting-disconnecting loop after the WiFi is restarted, has now been applied to the Azure_IoT_Central_ESP32_AzureIoTKit.ino example file.
The following bugs were detected when doing further testing (both in the pre-previous bug fix code and post-previous bug fix code): - When internet is no longer available while WiFi is still connected and then internet comes back on, ESP32 cannot connect to Azure IoT Central server - When internet goes off during inital provisioning stage, Azure IoT Central Operation ID becomes corrupted - When WiFi is restarted without internet connectivity, ESP32 gets stuck in an infinite Azure IoT connection loop which leads to memory exhaust
|
Hi @danewalton. Just FYI, this is another bug I came accross while working on my project. If you could check it out whenever you've got some free time, I'm sure this would benifit others also |
| @@ -406,14 +411,22 @@ void loop() | |||
| { | |||
| if (WiFi.status() != WL_CONNECTED) | |||
| { | |||
| azure_iot_stop(&azure_iot); | |||
| if (azure_iot.state != azure_iot_state_not_initialized) | |||
| azure_iot_stop(&azure_iot); | |||
There was a problem hiding this comment.
Within azure_iot_stop the first check is if azure_iot->state == azure_iot_state_not_initialized.
If azure_iot is azure_iot_state_not_initialized, nothing is done by azure_iot_stop.
So the only reason to check here again is to avoid printing error logs? Remember that this is a sample, so for a production scenario customers can just remove the logging from azure_iot_stop.
| connect_to_wifi(); | ||
|
|
||
| if (!azure_initial_connect) |
There was a problem hiding this comment.
Now these two are more serious. This is probably coming because there is possible data corruption when there is wifi disconnection. This seems plausible. We will run a few more tests here.
| case azure_iot_disconnected: | ||
| azure_iot_start(&azure_iot); | ||
| WiFi.disconnect(); |
There was a problem hiding this comment.
So here this is more aggressive trying to re-establish connection with Azure IoT Hub. It is a more guaranteed way of doing so, but also more costly (due to a full internet reconnection).
We can do it that way, it will make the sample more reliable, I believe. Remembering that this is just a sample, not production code.
|
Code changes merged through PR #56 |
The following bugs were detected when doing further testing (both in the pre-previous bug fix code and post-previous bug fix code):