[Storage] Support Managepolicy policy on 2018-03-01-preview #4367

blueww · 2018-05-25T03:20:30Z

Description

This PR is generated from swagger in private repo, will update to public repo when the swagger PR for public repo is merged.
But the code should be the same, so please help to start review now.
The feature target to release on 5/30.

The swagger PR:
Private: pass review on private repo: Azure/azure-rest-api-specs-pr#465
Public: just sent to public repo: Azure/azure-rest-api-specs#3137

Rest API Spec: https://microsoft-my.sharepoint.com/:w:/r/personal/yzheng_ntdev_microsoft_com/_layouts/15/Doc.aspx?sourcedoc=%7B3E66A1C5-12C8-4ACB-BCF0-D59B015DE394%7D&file=DLMPreviewDoc.docx&action=default&mobileredirect=true

Breaking:
Per onesdk team requirement in issue Azure/azure-rest-api-specs#3024, change Usage to Usages, since operation ID should not be singleton.

Upgrade SDK version to 8.0.0-preview since the breaking.

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

blueww · 2018-05-25T10:04:38Z

@shahabhijeet

The build failed since a Test case fail.
It seems the failure is not related with my code change, would you please help to fix it and build?

21:05:12 [xUnit.net 00:00:01.8712997] TestFramework.Tests.TestEnvironment.TestEnvironmentTests.DefaultTenantInTestEnvironment [FAIL]
21:05:12 [xUnit.net 00:00:01.8735540] System.AggregateException : One or more errors occurred. (AADSTS70002: Error validating credentials. AADSTS50012: Invalid client secret is provided.
21:05:12 [xUnit.net 00:00:01.8738628] Trace ID: d8de02bd-3b48-4661-be8a-a0d67c6a1d00
21:05:12 [xUnit.net 00:00:01.8739711] Correlation ID: 671433c7-97df-44d2-865c-ed0731794485
21:05:12 [xUnit.net 00:00:01.8740656] Timestamp: 2018-05-25 04:05:11Z)

dsgouda · 2018-05-25T16:35:47Z

src/SDKs/_metadata/storage_resource-manager.txt

-GitHub user: Azure
-Branch:      master
-Commit:      96d9da589ae6610fc816fca6b25288519974c83a
+GitHub user: blueww


Please generate the code from the Azure rest spec repo's master branch, we cannot accept PRs from code generated from a REST spec from a different repo/branch

Please create a generate.ps1 similar to this and regenerate the code

The PR has been re-generated on public swagger master branch, as the swagger is just merged.
I send the SDK PR for review first from private repo in advance before swagger PR is merged, since would like to have the PR review sooner to avoid risk of get review comments later.

Ｉ have already added generate.ps1 before. And now update it as the sample you provide. But the new script is not tested? Please help to review. Is there a way to test it?

dsgouda · 2018-05-25T18:53:51Z

src/SDKs/Storage/Management.Storage/Microsoft.Azure.Management.Storage.csproj

@@ -7,7 +7,7 @@
 		<PackageId>Microsoft.Azure.Management.Storage</PackageId>
 		<Description>Microsoft Azure Management Storage Library</Description>
 		<AssemblyName>Microsoft.Azure.Management.Storage</AssemblyName>
-		<Version>7.2.0-preview</Version>
+		<Version>8.0.0-preview</Version>
 		<PackageTags>Microsoft Azure Storage management;Storage;Storage management;</PackageTags>
 		<PackageReleaseNotes>See https://aka.ms/asdotnetsdkchangelog for release notes.</PackageReleaseNotes>


Please confirm that the package release notes are updated

nit: Is there a reason you plan to release a major version, you can release preview breaking changes by bumping the minor version too

Where's the package release notes? Do you mean the change log? I have updated it.

I update the major version just for the breaking change. Although we still in preview, we use the GA quality bar.

dsgouda · 2018-05-25T18:55:04Z

src/SDKs/Storage/Storage.Tests/Tests/StorageAccountTests.cs

@@ -1170,12 +1148,27 @@ public void StorageAccountUpdateEncryptionTest()
                Assert.Equal(true, account.Encryption.Services.File.Enabled);
                Assert.NotNull(account.Encryption.Services.File.LastEnabledTime);

-                // 2. Update storage encryption by enable Blob Encyrption
+                //// 2. Explicitly disable file encryption service.


We generally discourage commented code. It's best to move this code to a different test and mark it as Skipped

Good catch.
Fixed.

dsgouda · 2018-05-29T16:24:24Z

@blueww Please pull down latest upstream changes and update the PR

dsgouda

LGTM, will merge on CIs passing

blueww added 7 commits May 23, 2018 17:12

[Storage] Support Data LifeCycle

90372d7

[Storage] Use Object as rules input type and fix Unit test

05eaa97

Add new SRP features for 2018-03-01-preview

0b2eac8

[Storage] Update since rest api change

d958714

[Storage] Update from latest swagger in branch managepolicy

bb36c37

Update from latest swagger in merged201803

cce7537

[Storage] Update Unit Test for 2018-03-01-preview

2505004

blueww force-pushed the managepolicy branch from 6917663 to 2505004 Compare May 25, 2018 03:23

dsgouda suggested changes May 25, 2018

View reviewed changes

dsgouda added the Changes Requested label May 25, 2018

[Storage] revise as review comments.

8a0a5a1

blueww force-pushed the managepolicy branch from 7b2e943 to 8a0a5a1 Compare May 28, 2018 05:15

dsgouda approved these changes May 29, 2018

View reviewed changes

Merge branch 'psSdkJson6' into managepolicy

806df8c

dsgouda removed the Changes Requested label May 29, 2018

dsgouda merged commit 68a092d into Azure:psSdkJson6 May 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Storage] Support Managepolicy policy on 2018-03-01-preview #4367

[Storage] Support Managepolicy policy on 2018-03-01-preview #4367

blueww commented May 25, 2018 •

edited

Loading

blueww commented May 25, 2018 •

edited

Loading

dsgouda May 25, 2018

blueww May 28, 2018 •

edited

Loading

dsgouda May 25, 2018

dsgouda May 25, 2018

blueww May 28, 2018

dsgouda May 25, 2018

blueww May 28, 2018

dsgouda commented May 29, 2018

dsgouda left a comment •

edited

Loading

[Storage] Support Managepolicy policy on 2018-03-01-preview #4367

[Storage] Support Managepolicy policy on 2018-03-01-preview #4367

Conversation

blueww commented May 25, 2018 • edited Loading

Description

blueww commented May 25, 2018 • edited Loading

Choose a reason for hiding this comment

blueww May 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dsgouda commented May 29, 2018

dsgouda left a comment • edited Loading

Choose a reason for hiding this comment

blueww commented May 25, 2018 •

edited

Loading

blueww commented May 25, 2018 •

edited

Loading

blueww May 28, 2018 •

edited

Loading

dsgouda left a comment •

edited

Loading