-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[AzureMonitorDistro] Remove logs sampling. #44745
Merged
rajkumar-rangaraj
merged 3 commits into
Azure:main
from
rajkumar-rangaraj:rajrang/removeLogsSampling
Jun 27, 2024
Merged
[AzureMonitorDistro] Remove logs sampling. #44745
rajkumar-rangaraj
merged 3 commits into
Azure:main
from
rajkumar-rangaraj:rajrang/removeLogsSampling
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkumar-rangaraj
requested review from
cijothomas,
reyang,
TimothyMothra and
vishweshbankwar
as code owners
June 26, 2024 22:51
API change check API changes are not detected in this pull request. |
cijothomas
reviewed
Jun 26, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/LogFilteringProcessor.cs
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/AzureMonitorAspNetCoreEventSource.cs
Show resolved
Hide resolved
TimothyMothra
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some minor comments.
One more thing; when we spoke offline you proposed moving the LogFilteringProcessor to the Demo project. Are you still planning on doing this?
auto-merge was automatically disabled
June 27, 2024 00:32
Pull request was closed
tejasm-microsoft
pushed a commit
to tejasm-microsoft/azure-sdk-for-net
that referenced
this pull request
Jul 22, 2024
* Remove logs sampling. * changelog update * pr feedback - changelog
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.