[Storage] STG 88 Archboard Review Feedback (#30129)

Azure · Apr 28, 2023 · d3df623 · d3df623
1 parent 2b63352
commit d3df623
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_directory_client.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_directory_client.py
@@ -564,7 +564,7 @@ def list_directories_and_files(self, name_starts_with=None, **kwargs):
 
     @distributed_trace
     def list_handles(self, recursive=False, **kwargs):
-        # type: (bool, Any) -> ItemPaged
+        # type: (bool, Any) -> ItemPaged[Handle]
         """Lists opened handles on a directory or a file under the directory.
 
         :param bool recursive:

diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
@@ -466,7 +466,7 @@ class Handle(DictMixin):
      the handle has last been reconnected. (UTC)
     :keyword ~datetime.datetime last_reconnect_time: Time handle was last connected to (UTC)
     :keyword access_rights: Access rights of the handle.
-    :paramtype access_rights: List[Literal['Read', 'Write', 'Delete']]
+    :paramtype access_rights: Optional[List[Literal['Read', 'Write', 'Delete']]]
     """
 
     def __init__(self, **kwargs):

diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_directory_client_async.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_directory_client_async.py
@@ -442,7 +442,7 @@ def list_directories_and_files(self, name_starts_with=None, **kwargs):
 
     @distributed_trace
     def list_handles(self, recursive=False, **kwargs):
-        # type: (bool, Any) -> AsyncItemPaged
+        # type: (bool, Any) -> AsyncItemPaged[Handle]
         """Lists opened handles on a directory or a file under the directory.
 
         :param bool recursive:

diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_file_client_async.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_file_client_async.py
@@ -1394,7 +1394,7 @@ async def resize_file(self, size, **kwargs):
 
     @distributed_trace
     def list_handles(self, **kwargs):
-        # type: (Any) -> AsyncItemPaged
+        # type: (Any) -> AsyncItemPaged[Handle]
         """Lists handles for file.
 
         :keyword int timeout: