Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable Pyproject Inclusion #28345

Merged
merged 46 commits into from
Jan 20, 2023
Merged

Enable Pyproject Inclusion #28345

merged 46 commits into from
Jan 20, 2023

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jan 13, 2023

See eng_sys_checks.md for updated documentation.

  • Add pyproject.toml with custom tool section [tool.azure-sdk-build] to all core packages.
    • This new section allows users to enable/disable checks at the package level.
    • I will script out an update for the entire repository that pulls the remaining package definitions from environment_exclusions.py into individual pyproject.toml where necessary.
    • This is where the optional definitions will live.
  • Enables black on the t2 packages under azure-core with the new ability to ignore checks on packages.
  • Disables all packages with Inactive classifier from building/checks. If you want to re-enable, set queue time variable ENABLE_PACKAGE_NAME=true. Replace - with _.
  • Allows custom override of enable/disable at the individual check level. PACKAGE_NAME_CHECK=true.
    • AZURE_CORE_PYLINT=true
    • AZURE_EVENTHUB_PYLINT=false <- to disable when it's enabled by default
  • Marks a couple packages as inactive as they have been placed under the exclude due to long periods of disable/brokenness.

Well TIL! The management automation accidentally picks up the pyproject.toml instead of the sdk_packaging.toml file. Will repair that.

PENDING:

  • Repair update_pr
  • Update spellcheck so that Build Analyze passes.

Resolves #28167

scbedd added 23 commits January 5, 2023 17:54
…ing the inactive tag. simplify discover_targeted_packages to be more readable in preparation for refactor
… with functions.py. time to finish work in environment_exclusions.py
@scbedd
Copy link
Member Author

scbedd commented Jan 19, 2023

/azp run python - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Jan 19, 2023

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor inactive package classifier, skip deprecated packages by default
5 participants