[Storage] [STG88] Owner, group, permissions in DirectoryProperties and FileProperties
#29491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenttran-msft
requested review from
annatisch and
jalauzon-msft
as code owners
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
vincenttran-msft
changed the title
PathPropertiesDirectoryProperties and FileProperties
jalauzon-msft
approved these changes
Mar 23, 2023
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_deserialize.py
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_models.py
Outdated
Show resolved
Hide resolved
vincenttran-msft
deleted the
vincenttran/owner_group_perm_pathproperties
branch
vincenttran-msft
added a commit
that referenced
this pull request
May 3, 2023
* Initial STG87 feature branch setup * Revert "Initial STG87 feature branch setup" This reverts commit 8b43aa2. * [Storage] Initial STG88 feature branch setup (#29401) * Initial STG88 feature branch setup * Add version * [Storage] [STG88] High throughput append blob (#29442) * Added comments + sync&async test * Remove comments * [Storage] [STG88] Owner, group, permissions in `DirectoryProperties` and `FileProperties` (#29491) * Added testcases * Added owner,group,permissions to DirectoryProperties and FileProperties * PR feedback, update properties docstrnig * [Storage] [STG88] List Handles Access Rights (#29581) * Done sync&async * Remove preprod from base_client * [Storage] Add `encryption_context` kwarg to `upload_data` API (#29893) * Upload + async/sync tests * Version drop * Datalake-blob dependency, bring back version * Use param instead of kwarg (#29925) * paramtype not param (#29927) * [Storage] STG 88 Archboard Review Feedback (#30129) * Changelog
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testcases to check that owner, group, and permissions are returned in path properties.
However, it seems like this has already been the case since the initial ADLS gen2 implementation?
Here is a link to the PathProperties implementation and has been present since ADLS Gen2 API Impelmentation (4 years ago).
EDIT: Actual feature is to add to
DirectoryPropertiesandFilePropertiesresponse 😄