Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add docstring to indicate only one agent_pool_profile can be in the list #3256

Closed
wants to merge 1 commit into from
Closed

Add docstring to indicate only one agent_pool_profile can be in the list #3256

wants to merge 1 commit into from

Conversation

WebSpider
Copy link

Enhance documentation so limit of one agent_pool_profile per managed_cluster is more clear

@WebSpider WebSpider requested a review from lmazuel as a code owner September 2, 2018 06:03
@codecov-io
Copy link

codecov-io commented Sep 2, 2018

Codecov Report

Merging #3256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3256   +/-   ##
=======================================
  Coverage    55.2%    55.2%           
=======================================
  Files        9198     9198           
  Lines      184891   184891           
=======================================
  Hits       102070   102070           
  Misses      82821    82821
Impacted Files Coverage Δ
...re/mgmt/containerservice/models/managed_cluster.py 27.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a76ec8...cbac577. Read the comment docs.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@lmazuel
Copy link
Member

lmazuel commented Sep 4, 2018

@mboersma ?

@mboersma
Copy link
Member

mboersma commented Sep 5, 2018

Yes, this is a good clarification--thanks! Only one AKS node (agent) pool is supported currently.

But shouldn't we make this change here, in the Swagger spec so it propagates to all the SDKs?

@WebSpider
Copy link
Author

WebSpider commented Sep 5, 2018 via email

@lmazuel
Copy link
Member

lmazuel commented Sep 5, 2018

Yes @mboersma , it has to be done in the Swagger. But at first I wasn't even sure it was accurate :). Could you fix the Swagger and link this issue? Thanks!

@mboersma
Copy link
Member

mboersma commented Sep 7, 2018

Swagger PR opened at Azure/azure-rest-api-specs#3835.

@lmazuel
Copy link
Member

lmazuel commented Sep 7, 2018

Done in #3298

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants