Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[AutoPR graphrbac/data-plane] [graphrbac]: fix bugs in permission grant apis #4339

Merged
merged 17 commits into from
Mar 13, 2019

Conversation

AutorestCI
Copy link
Contributor

[graphrbac]: fix bugs in permission grant apis
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Feb 9, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-graphrbac

You can install the package azure-graphrbac of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5181#egg=azure-graphrbac&subdirectory=azure-graphrbac"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5181#egg=azure-graphrbac&subdirectory=azure-graphrbac"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_5181
  • pip install -e ./azure-graphrbac

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_5181
  • pip wheel --no-deps ./azure-graphrbac

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Feb 9, 2019

Codecov Report

Merging #4339 into restapi_auto_graphrbac/data-plane will decrease coverage by 1.32%.
The diff coverage is 80.5%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           restapi_auto_graphrbac/data-plane    #4339      +/-   ##
=====================================================================
- Coverage                              54.21%   52.88%   -1.33%     
=====================================================================
  Files                                  10106    11869    +1763     
  Lines                                 205576   263085   +57509     
=====================================================================
+ Hits                                  111457   139140   +27683     
- Misses                                 94119   123945   +29826
Impacted Files Coverage Δ
...rbac/models/service_principal_update_parameters.py 100% <100%> (ø) ⬆️
...ac/azure/graphrbac/models/informational_url_py3.py 100% <100%> (ø)
...ac/azure/graphrbac/graph_rbac_management_client.py 97.72% <100%> (ø) ⬆️
...rbac/models/service_principal_create_parameters.py 100% <100%> (ø) ⬆️
...aphrbac/azure/graphrbac/models/application_base.py 100% <100%> (ø)
...c/azure/graphrbac/models/service_principal_base.py 100% <100%> (ø)
.../models/service_principal_update_parameters_py3.py 100% <100%> (ø) ⬆️
...hrbac/models/graph_rbac_management_client_enums.py 100% <100%> (ø) ⬆️
.../graphrbac/models/application_update_parameters.py 57.14% <100%> (+32.14%) ⬆️
...bac/azure/graphrbac/models/application_base_py3.py 100% <100%> (ø)
... and 2434 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf5441...23d52d5. Read the comment docs.

@AutorestCI AutorestCI merged commit 228163d into restapi_auto_graphrbac/data-plane Mar 13, 2019
@AutorestCI AutorestCI deleted the restapi_auto_5181 branch March 13, 2019 17:59
@AutorestCI
Copy link
Contributor Author

This PR has been merged into #3971

lmazuel pushed a commit that referenced this pull request Mar 13, 2019
* Generated from 4ded5c602af2dccc26fe7b069bc9def8464a02b8 (#3941)

typo: graphrbac

- otherwsie -> otherwise
- Objectit -> Object
- Reqired -> Required

* Generated from 10e5ed698dece8c082c064680537ebae7f3a14b7 (#4009)

updating file due to not desired automatic formatting

* Packaging update of azure-graphrbac

* [AutoPR graphrbac/data-plane] [graphrbac]: fix bugs in permission grant apis (#4339)

* Generated from 2dadc0120aabb2c09c4dc28ffa15e6cce0d732fe

[graphrbac]: fix bugs in permission grant apis

* Packaging update of azure-graphrbac

* Generated from c836f65f03517885f00e2b9a7e9cb66a825f9573

fix paging

* Generated from bd1f9051db4982f74c8fee38b4775a9c1a84dae2

add missing property

* Generated from 9d1138759b208cdff1dfb5c95ad017f3d65e5910

remove pageable

* Generated from 4617a515d7822d49f0f31bf6fc35713af3557eaa

author pagable in the right way

* Generated from c39738f462ee4cd7531d1568029a671a50bdd134

breaking changes over a wrong spec

* Generated from 0d475d3f50a22427a308fcd608bef1f0af4cabfc

workaround

* Generated from 11ead891155579cfc936880b7e4a6c5bf76ddd9f

remove additionalProperties which causes wrong code-gen

* Generated from 1a5f6ad61fee705757bb93fe95210220eae3a218

address review feedabck

* Packaging update of azure-graphrbac

* Generated from 590f27f4d25733f1e9741363690a8fa595b94fe7

moev ahead with the established pattern anyway

* Packaging update of azure-graphrbac

* Generated from 21bcf7ed4779c90a805e5b2fc1c2bb5736743cf2

address review feedbacks

* Generated from 2f2d0884b67b616ccdf637fb03dceec557a6e5ee

clean up all

* Generated from cc2979ca161aa49f917146542d14240d3f744d66

update operation id

* Generated from 62cb9a6bdbc42ddde72e10b0a5dd124c4ad67052

add one more property per CLI user's ask

* 0.60.0
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants