Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve "like-types" collapsing #4438

Open
matthchr opened this issue Nov 11, 2024 · 0 comments
Open

Improve "like-types" collapsing #4438

matthchr opened this issue Nov 11, 2024 · 0 comments
Assignees
Milestone

Comments

@matthchr
Copy link
Member

Fix hacky change applied in #4430. Instead of this, create a new stage that can merge "like" types within a group.

Doing this may require comparing a bunch of types. We may need to do some optimization such as pre-computing the number of properties on objectTypes and only comparing ObjectTypes that have the same number of properties if it's really slow.
Alternatively, only looking for types that match a certain type (so it's O(N) rather than O(N^2).

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Development

No branches or pull requests

1 participant