Deduplicate SubResource for networking #4430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the SubResource from DnsResolver to match the SubResource from core networking so that we don't have a million different <Resource>SubResource's created. The issue is that dnsresolver and networking are two different Swagger specifications from two different Swagger folders that both put resources into the networking group. The 2022-07-01 API just happened to be supported by both networking and dnsresolver, but many subsequent API versions of plain networking don't correspond to a dnsresolver version. This results in inconsistencies between type names in the two versions of core networking which causes issues adding a new networking version due to conversion problems.
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
|
Planning to file an item to do this in a less hacky way, although I don't really know what a less hacky way would be... |
|
/ok-to-test sha=3a0dd50 |
matthchr
changed the title
theunrepentantgeek
approved these changes
Nov 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the SubResource from DnsResolver to match the SubResource from core networking so that we don't have a million different SubResource's created.
The issue is that dnsresolver and networking are two different Swagger specifications from two different Swagger folders that both put resources into the networking group. The 2022-07-01 API just happened to be supported by both networking and dnsresolver, but many subsequent API versions of plain networking don't correspond to a dnsresolver version. This results in inconsistencies between type names in the two versions of core networking which causes issues adding a new networking version due to conversion problems.