You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now the suite_test.go and the test context (tc) have eventhub namespace, storage account and blob containers all used only for the eventhub controller tests. The Suite_test.go setup and the test context are used across all tests and so should be refactored to not include any event hub specific resources. Only the resource group used for all tests should be created in this file and should be in the test context
After I opened this issue, I had to do the same for the Azure Sql database tests as it looks like some of the time taking resources like SQL server might benefit from being created here. So this is something we should discuss before implementing.
**Done criteria **
This is the "done" criteria for this task
Suite_test.go does not have creation of anything else other than resource group
test context does not have eventhub namespace, blob container etc. which are only used for eventhub tests, this should be in the BeforeEach() block for each of those test files instead
User story reference
#
The text was updated successfully, but these errors were encountered:
jananivMS
changed the title
Task: Tests: Refactor out creation of any other resources other than resource group from suite_test.go
Task: [Discuss] Tests: Refactor out creation of any other resources other than resource group from suite_test.go
Nov 5, 2019
This is called `TypeMerger` but it is really multiple dispatch for functions with type `([some Type], [some Type]) → Type`. Ideally this would be a bit more generalized to _n_ arguments but Go doesn’t support that kind of thing.
Right now the suite_test.go and the test context (tc) have eventhub namespace, storage account and blob containers all used only for the eventhub controller tests. The Suite_test.go setup and the test context are used across all tests and so should be refactored to not include any event hub specific resources. Only the resource group used for all tests should be created in this file and should be in the test context
After I opened this issue, I had to do the same for the Azure Sql database tests as it looks like some of the time taking resources like SQL server might benefit from being created here. So this is something we should discuss before implementing.
**Done criteria **
This is the "done" criteria for this task
User story reference
#
The text was updated successfully, but these errors were encountered: