Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Task: [Discuss] Tests: Refactor out creation of any other resources other than resource group from suite_test.go #445

Closed
2 tasks
jananivMS opened this issue Nov 5, 2019 · 0 comments · Fixed by #971
Assignees
Labels
test Test refactoring related tasks

Comments

@jananivMS
Copy link
Contributor

jananivMS commented Nov 5, 2019

Right now the suite_test.go and the test context (tc) have eventhub namespace, storage account and blob containers all used only for the eventhub controller tests. The Suite_test.go setup and the test context are used across all tests and so should be refactored to not include any event hub specific resources. Only the resource group used for all tests should be created in this file and should be in the test context

After I opened this issue, I had to do the same for the Azure Sql database tests as it looks like some of the time taking resources like SQL server might benefit from being created here. So this is something we should discuss before implementing.

**Done criteria **
This is the "done" criteria for this task

  • Suite_test.go does not have creation of anything else other than resource group
  • test context does not have eventhub namespace, blob container etc. which are only used for eventhub tests, this should be in the BeforeEach() block for each of those test files instead

User story reference

#

@jananivMS jananivMS added task test Test refactoring related tasks labels Nov 5, 2019
@jananivMS jananivMS changed the title Task: Tests: Refactor out creation of any other resources other than resource group from suite_test.go Task: [Discuss] Tests: Refactor out creation of any other resources other than resource group from suite_test.go Nov 5, 2019
@jananivMS jananivMS added P2 and removed P1 labels Nov 13, 2019
@jananivMS jananivMS self-assigned this Apr 18, 2020
Porges added a commit that referenced this issue May 11, 2021
This is called `TypeMerger` but it is really multiple dispatch for functions with type `([some Type], [some Type]) → Type`. Ideally this would be a bit more generalized to _n_ arguments but Go doesn’t support that kind of thing.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test Test refactoring related tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant