-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update kubernetesConfiguration.fluxConfiguration
resource version to 2024-11-01
#4638
Update kubernetesConfiguration.fluxConfiguration
resource version to 2024-11-01
#4638
Conversation
v2/samples/kubernetesconfiguration/v1api/v1api20241101_fluxconfiguration.yaml
Outdated
Show resolved
Hide resolved
You've updated the submodule, which brings with it changes upstream that teams have made to their specs. Usually this is just docs but every once in a while there are actual structural changes to existing API versions (almost always because the published spec actually was wrong and didn't work)
Docs will be automatic. Tests you'll have to add (see my comments) |
Thanks for the PR, much appreciated.
We're targeting mid-April for the release of ASO v2.13, which isn't far off. Also, as soon as your PR merges, we'll automatically publish a new experimental release which you can immediately use for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor tweaks, including a missing recording of the sample, but otherwise looks great.
Thanks for your contribution. We're looking forward to merging this.
We need to first merge PR #4640 as a cleanup, then we should be clear to merge this one once CI passes.
v2/samples/kubernetesconfiguration/v1api/v1api20241101_fluxconfiguration.yaml
Outdated
Show resolved
Hide resolved
@@ -14,7 +14,7 @@ import ( | |||
"github.com/Azure/azure-service-operator/v2/internal/util/to" | |||
) | |||
|
|||
func Test_KubernetesConfiguration_FluxConfiguration_CRUD(t *testing.T) { | |||
func Test_KubernetesConfiguration_FluxConfiguration_20230501_CRUD(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming this test is the right thing to do - but you'll need to rerecord the test. This is failing in CI with this error:
=== RUN Test_KubernetesConfiguration_FluxConfiguration_20230501_CRUD
=== PAUSE Test_KubernetesConfiguration_FluxConfiguration_20230501_CRUD
=== CONT Test_KubernetesConfiguration_FluxConfiguration_20230501_CRUD
kube_per_test_context.go:167: creating recorder: required environment variable "AZURE_SUBSCRIPTION_ID" was not supplied
--- FAIL: Test_KubernetesConfiguration_FluxConfiguration_20230501_CRUD (0.00s)
This error appears when there's no recording for the test.
Some background: The test recording is named for the test (so the old test recording is Test_KubernetesConfiguration_FluxConfiguration_CRUD.yaml
). But, the name of the test is also used to seed a random number generator that's used to generate unique names within the test, so it can't simply be renamed.
Delete the old file and create a new recording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed Test_KubernetesConfiguration_FluxConfiguration_CRUD
to Test_KubernetesConfiguration_FluxConfiguration_20230501_CRUD
and updated the test as it was failing on my side (the flux extension was never installed on the cluster).
I remade several tests (see the commit content)
v2/internal/controllers/kubernetesconfiguration_fluxconfiguration_20241101_test.go
Show resolved
Hide resolved
v2/samples/kubernetesconfiguration/v1api/v1api20241101_fluxconfiguration.yaml
Outdated
Show resolved
Hide resolved
151778c
to
62ad786
Compare
v2/samples/kubernetesconfiguration/v1api/v1api20241101_extension.yaml
Outdated
Show resolved
Hide resolved
/ok-to-test sha=059f5d3 |
Add support for
kubernetesConfiguration.fluxConfiguration
resource to version to2024-11-01
so that it supports thespec.gitRepository.provider
property.Notes: to generate the code I ran the
task
cmd but it also updated other resources about ACR. Is this something normal?I did not write documentation nor tests, did I miss something?
We need this feature ASAP for a customer delivery. Do you have an estimated date for the next ASO release?