Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

rename eventhub sample manifests #76

Merged
merged 1 commit into from
Aug 15, 2019
Merged

rename eventhub sample manifests #76

merged 1 commit into from
Aug 15, 2019

Conversation

frodopwns
Copy link
Contributor

When kubebuilder is used to scaffold an operator, the name chosen for sample files is: {group}_{version}_{name}.yaml

For this reason, we want to make the current samples match the future scheme

@frodopwns frodopwns self-assigned this Aug 13, 2019
@frodopwns frodopwns mentioned this pull request Aug 15, 2019
Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@frodopwns frodopwns merged commit f86a765 into Azure:master Aug 15, 2019
@frodopwns frodopwns deleted the sample-rename branch August 15, 2019 21:11
Porges added a commit that referenced this pull request May 11, 2021
Validate properties that are `Required`, and make optional properties into pointers.

Support for `Enum` validation comment is added but not yet used.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants