Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move Global Log-Level #2452

Closed
RubenCerna2079 opened this issue Nov 6, 2024 · 2 comments · Fixed by #2508
Closed

Move Global Log-Level #2452

RubenCerna2079 opened this issue Nov 6, 2024 · 2 comments · Fixed by #2508
Assignees
@RubenCerna2079
Milestone
1.4

Comments

@RubenCerna2079
Copy link
Contributor

As of this moment, the log-level property is globally found under /runtime, this property should be moved to /runtime/telemetry. Once the property is moved and it is shown to be working properly, log-level should be added to the JSON schema.
@JerryNixon
Copy link
Contributor

Is there a target milestone?

@RubenCerna2079 RubenCerna2079 added this to the 1.4 milestone Dec 13, 2024
@RubenCerna2079 RubenCerna2079 self-assigned this Dec 13, 2024
@RubenCerna2079 RubenCerna2079 mentioned this issue Jan 7, 2025
Merged
2 tasks
@RubenCerna2079 RubenCerna2079 linked a pull request Jan 7, 2025 that will close this issue
Move Global Log-Level #2508
Merged
2 tasks
RubenCerna2079 added a commit that referenced this issue Jan 14, 2025
@RubenCerna2079 @abhishekkumams
Move Global Log-Level (#2508)
b3f2ff6 
## Why make this change?

Solves #2452

## What is this change?

Moves the log-level property from `/runtime` to `/runtime/telemetry`
where it was decided it should live. It also changes the files so that
the log-level property is under `TelemetryOptions` instead of
`RuntimeOptions` and fix any tests related to the changes.

## How was this tested?

- [X] Integration Tests
- [ ] Unit Tests

---------

Co-authored-by: Ruben Cerna <rcernaserna@microsoft.com>
Co-authored-by: Abhishek  Kumar <102276754+abhishekkumams@users.noreply.github.com>
@JerryNixon
Copy link
Contributor

original #2371

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@RubenCerna2079 RubenCerna2079

Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

Move Global Log-Level Azure/data-api-builder
2 participants
@JerryNixon @RubenCerna2079