Configure and updated Runtime HOST settings using in CLI #2455
+397
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezal98
requested review from
Aniruddh25,
seantleonard,
aaronburtle,
abhishekkumams,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592 and
sourabh1007
as code owners
This was
linked to
issues
Nov 10, 2024
|
/azp run |
|
/azp run |
abhishekkumams
approved these changes
Nov 17, 2024
JerryNixon
reviewed
Nov 17, 2024
JerryNixon
reviewed
Nov 17, 2024
…/github.com/Azure/data-api-builder into dev/sezalchug/addConfigureHostRuntimeConfig
|
/azp run |
|
/azp run |
…/github.com/Azure/data-api-builder into dev/sezalchug/addConfigureHostRuntimeConfig
|
/azp run |
aaronburtle
reviewed
Nov 20, 2024
|
/azp run |
|
/azp run |
abhishekkumams
deleted the
dev/sezalchug/addConfigureHostRuntimeConfig
branch
Aniruddh25
reviewed
Nov 22, 2024
| updatedValue = options?.RuntimeHostMode; | ||
| if (updatedValue != null) | ||
| { | ||
| updatedHostOptions = updatedHostOptions! with { Mode = (HostMode)updatedValue }; |
There was a problem hiding this comment.
is updatedHostOptions guaranteed to be not null here? If yes, why do we have the argument to the function defined to be nullable?
Aniruddh25
reviewed
Nov 22, 2024
| } | ||
| else | ||
| { | ||
| jwtOptions = updatedHostOptions.Authentication.Jwt with { Issuer = (string)updatedValue }; |
There was a problem hiding this comment.
IIRC, Authentication.Jwt and can have audience and issuer values only when Authentication.Provider is Jwt. Can we validate before updating audience/issuer values that Provider is Jwt? If not, fail the update?
abhishekkumams
pushed a commit
that referenced
this pull request
Nov 28, 2024
## Why make this change? Resolved issue #2420 This change is made to enable dab users to update/change values of Rest and Cache runtime settings from CLI commands. <img width="665" alt="image" src="https://github.com/user-attachments/assets/7be7f69a-2621-4cb3-8283-9087df04b2b2"> ## What is this change? 1. Made changes in ConfigureOptions.cs to include the additional parameters for Host Runtime settings. 2. Changes in ConfigureGenerator.cs to include the function to update the newly incoming values in the parameters of Host runtime settings 3. Changes in Tests to add individual tests for all Host individual runtime settings like Host: Mode, Cors.Origins, Cors.AllowCredentials, Authentication.Provider, Authentication.Jwt.Audience, Authentication.Jwt.Issuer. ## How was this tested? - [x] Integration Tests - [x] Unit Tests ## Sample Request(s) `dab configure --runtime.host.mode {value} -c {Config-File-Name}` <img width="662" alt="mode" src="https://github.com/user-attachments/assets/81e4208e-1719-4948-ac59-b1d4625997f6"> `dab configure --runtime.host.cors.origins {value} -c {Config-File-Name}` <img width="662" alt="corsOrigins" src="https://github.com/user-attachments/assets/7370cae5-56bb-49c6-abcb-6522819b1da5"> `dab configure --runtime.host.cors.allow-credentials {value} -c {Config-File-Name}` <img width="655" alt="corsAllow" src="https://github.com/user-attachments/assets/bb31dc6a-31c0-4259-b2bb-e9c2535cdb3e"> `dab configure --runtime.host.authentication.provider {value} -c {Config-File-Name}` <img width="674" alt="provider" src="https://github.com/user-attachments/assets/03efd7c3-2370-45b9-9626-5ece37f2e6d7"> `dab configure --runtime.host.authentication.jwt.audience {value} -c {Config-File-Name}` <img width="671" alt="audience" src="https://github.com/user-attachments/assets/b4547bde-5520-47d0-84ab-c4f099ed3052"> `dab configure --runtime.host.authentication.jwt.issuer {value} -c {Config-File-Name}` <img width="669" alt="issuer" src="https://github.com/user-attachments/assets/1c71fee2-8a4c-4472-b012-a775a979a8a1"> --------- Co-authored-by: sezalchug <sezalchug@microsoft.com> Co-authored-by: aaronburtle <93220300+aaronburtle@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Resolved issue #2420
This change is made to enable dab users to update/change values of Rest and Cache runtime settings from CLI commands.
What is this change?
How was this tested?
Sample Request(s)
dab configure --runtime.host.mode {value} -c {Config-File-Name}dab configure --runtime.host.cors.origins {value} -c {Config-File-Name}dab configure --runtime.host.cors.allow-credentials {value} -c {Config-File-Name}dab configure --runtime.host.authentication.provider {value} -c {Config-File-Name}dab configure --runtime.host.authentication.jwt.audience {value} -c {Config-File-Name}dab configure --runtime.host.authentication.jwt.issuer {value} -c {Config-File-Name}