Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix namespace collision for string and CollectionUtils method IsNullOrEmpty #2471

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Fix namespace collision for string and CollectionUtils method IsNullOrEmpty #2471

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a3cdf9
fixing namespace collision
abhishekkumams Nov 20, 2024
a925ffd
only other usage of bad string null check
aaronburtle Nov 21, 2024
b508a80
Merge branch 'main' into dev/abhishekkuma/fix-namespace-collision
abhishekkumams Nov 21, 2024
0dedd27
Merge branch 'main' into dev/abhishekkuma/fix-namespace-collision
aaronburtle Nov 21, 2024
44926f2
renaming CollectionUtilities class
abhishekkumams Nov 25, 2024
c875d47
fix formatting
abhishekkumams Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/Resolvers/MsSqlQueryBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ private string MakeOutputColumns(List<LabelledColumn> columns, string columnPref
/// </summary>
private string Build(LabelledColumn column, string columnPrefix)
{
if (columnPrefix.IsNullOrEmpty())
if (string.IsNullOrEmpty(columnPrefix))
{
return $"{QuoteIdentifier(column.ColumnName)} AS {QuoteIdentifier(column.Label)}";
}
Expand Down